Fix visual issues when opening message tooltip. For the animation, it requires rendering the second InlineSidebar component on the top, so it could diffuse the message.
Before:
After:
Differential D4825
[native] Introduce `inlineSidebar` animation when opening message tooltip to avoid visual issues. • jacek on Aug 12 2022, 2:38 AM. Authored by Tags None Referenced Files
Details Fix visual issues when opening message tooltip. For the animation, it requires rendering the second InlineSidebar component on the top, so it could diffuse the message. Before: Tested the animation on both platforms for multimedia and text messages. Confirmed if "go to sidebar" animation is not affected.
Diff Detail
Event TimelineComment Actions Tested this locally and it looks great! The visual change of the tooltip 'fading' through the message when holding down on the message is nice. Once again adding @tomek and @atul as blocking. Edit, also looks as expected on Android (there's no emojis on the robotext message since I forgot to supply a reactions prop there): Comment Actions Based on @abosh's screenshots, it looks like this diff is attempting to land fake placeholder emojis on master... Comment Actions I was just playing around with the code, there are no placeholder emojis (I had to supply the reactions prop, etc.) Comment Actions Looks great! Tested it out on physical device and things are smooth. Defer to @ashoat on reviewing the Reanimated stuff, but looks like he's already accepted.
Comment Actions
I don't have time to get up to speed on all of this, so ideally somebody else on the team can take that on. If not I'll need some additional context from @jacek to review
Comment Actions Still confused. Sorry, I'm not a great reviewer for things like this... since I don't have much time per review, I sometimes need to be "spoonfed" the explanation more so than other reviewers
|