Paths

Table of Contentst

Differential D4827

[CI] Bump GH Actions OS versions
ClosedPublic
Actions

Authored by atul on Aug 12 2022, 8:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 3, 1:51 PM

	Unknown Object (File)
	Sun, Nov 3, 1:51 PM

	Unknown Object (File)
	Sun, Nov 3, 1:51 PM

	Unknown Object (File)
	Sun, Nov 3, 1:49 PM

	Unknown Object (File)
	Oct 7 2024, 11:12 PM

	Unknown Object (File)
	Sep 29 2024, 9:59 PM

	Unknown Object (File)
	Sep 24 2024, 3:37 PM

	Unknown Object (File)
	Sep 24 2024, 3:37 PM

View All 97 Files

Subscribers

Details

Reviewers

• abosh
varun
tomek
• jacek

Commits

rCOMM9556cdcce83c: [CI] Bump GH Actions OS versions

Summary

Bump Ubuntu-based workflows to ubuntu-22.04 from ubuntu-latest (which is ubuntu-20.04). The newer ubuntu-22.04 image comes with the version of shellcheck (0.8.0) that we want.. which will prevent the GH Actions workflow from failing. Bumped the other Ubuntu workflows as well to maintain consistency (suggested by @abosh)

While at it, bumping macOS version from macos-latest (which is macos-11) to macos-12.

Test Plan

See what happens

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Aug 12 2022, 8:17 AM

Herald added subscribers: • adrian, ashoat. · View Herald TranscriptAug 12 2022, 8:17 AM

atul published this revision for review.Aug 12 2022, 8:18 AM

atul edited the summary of this revision. (Show Details)

Accepting because we discussed this IRL. Also see this comment left by me for more context as to why ShellCheck was bumped to ubuntu-22.04.

This revision is now accepted and ready to land.Aug 12 2022, 8:20 AM

atul added 1 blocking reviewer(s): tomek.Aug 12 2022, 8:26 AM

This revision now requires review to proceed.Aug 12 2022, 8:26 AM

Harbormaster completed remote builds in B11345: Diff 15605.Aug 12 2022, 8:28 AM

varun accepted this revision.Aug 12 2022, 8:36 AM

atul removed 1 blocking reviewer(s): tomek.Aug 12 2022, 8:37 AM

This revision is now accepted and ready to land.Aug 12 2022, 8:37 AM

Closed by commit rCOMM9556cdcce83c: [CI] Bump GH Actions OS versions (authored by atul). · Explain WhyAug 12 2022, 8:38 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9556cdcce83c: [CI] Bump GH Actions OS versions.

Revision Contents
Changeset List

Path

Size

.github/

workflows/

2 lines

android_release.yml

2 lines

backup_build.yml

2 lines

2 lines

docker_keyserver.yml

2 lines

eslint_flow_jest.yml

2 lines

identity_build.yaml

2 lines

ios_release.yml

2 lines

remove_harbormaster_tags.yml

2 lines

12 lines

tunnelbroker_build.yaml

2 lines

Diff 15605

.github/workflows/android_ci.yml

Loading...

.github/workflows/android_release.yml

Loading...

.github/workflows/backup_build.yml

Loading...

.github/workflows/blob_build.yml

Loading...

.github/workflows/docker_keyserver.yml

Loading...

.github/workflows/eslint_flow_jest.yml

Loading...

.github/workflows/identity_build.yaml

Loading...

.github/workflows/ios_release.yml

Loading...

.github/workflows/remove_harbormaster_tags.yml

Loading...

.github/workflows/shellcheck.yml

Loading...

.github/workflows/tunnelbroker_build.yaml

Loading...