Paths

Table of Contentst

[web] Use dispatchActionPromise when logging out
ClosedPublic
Actions

Authored by tomek on Aug 16 2022, 4:28 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jun 13, 4:43 PM

	Unknown Object (File)
	Wed, Jun 5, 9:01 AM

	Unknown Object (File)
	Tue, Jun 4, 11:02 AM

	Unknown Object (File)
	May 27 2024, 1:51 AM

	Unknown Object (File)
	May 27 2024, 1:51 AM

	Unknown Object (File)
	May 27 2024, 1:46 AM

	Unknown Object (File)
	May 14 2024, 1:36 PM

	Unknown Object (File)
	Apr 20 2024, 3:24 PM

Subscribers

Details

Reviewers

• jacek
atul
ashoat

Commits

rCOMM5b9642aee34c: [web] Use dispatchActionPromise when logging out

Summary

Instead of calling server directly, we need to use dispatchActionPromise function, so that relevant redux actions are dispatched.
Fixes https://linear.app/comm/issue/ENG-1604/clean-enabled-apps-on-logout

Test Plan

Log out and check if logout success action was dispatched.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 16 2022, 4:28 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptAug 16 2022, 4:28 AM

Harbormaster completed remote builds in B11376: Diff 15645.Aug 16 2022, 4:37 AM

tomek requested review of this revision.Aug 16 2022, 4:37 AM

tomek added a child revision: D4848: [lib] Clear enabled apps on logout.Aug 16 2022, 5:09 AM

ashoat accepted this revision.Aug 16 2022, 5:09 AM

This revision is now accepted and ready to land.Aug 16 2022, 5:09 AM

Closed by commit rCOMM5b9642aee34c: [web] Use dispatchActionPromise when logging out (authored by tomek). · Explain WhyAug 17 2022, 6:07 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM5b9642aee34c: [web] Use dispatchActionPromise when logging out.

Revision Contents
Changeset List

Path

Size

web/

settings/

account-settings.react.js

19 lines

Diff 15712

View Options

web/settings/account-settings.react.js

[web] Use dispatchActionPromise when logging outClosedPublicActions