Page MenuHomePhabricator

[lib] Clear enabled apps on logout
ClosedPublic

Authored by tomek on Aug 16 2022, 5:09 AM.
Tags
None
Referenced Files
F3184668: D4848.id15713.diff
Fri, Nov 8, 11:27 AM
Unknown Object (File)
Thu, Nov 7, 7:10 AM
Unknown Object (File)
Thu, Nov 7, 6:30 AM
Unknown Object (File)
Thu, Nov 7, 4:23 AM
Unknown Object (File)
Thu, Nov 7, 2:15 AM
Unknown Object (File)
Thu, Nov 7, 1:11 AM
Unknown Object (File)
Wed, Nov 6, 11:18 AM
Unknown Object (File)
Tue, Nov 5, 8:44 AM

Details

Summary

When a user is logged out we should clear enabled apps.

Fixes https://linear.app/comm/issue/ENG-1617/handle-logout-in-enabled-apps-reducer
Depends on D4847

Test Plan

native: set calendar as enabled, log out, log in and check if calendar is disabled.
web: tested as a part of D4812

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Aug 16 2022, 5:19 AM

Choose default apps based on platform

tomek requested review of this revision.Aug 16 2022, 5:27 AM

Looks good

lib/reducers/enabled-apps-reducer.js
35 ↗(On Diff #15649)

Guessing you logged process.env on both web and native to ensure things were as expected.

This revision is now accepted and ready to land.Aug 16 2022, 2:01 PM
abosh retitled this revision from [lib] Clear enabled aps on logout to [lib] Clear enabled apps on logout.Aug 16 2022, 2:06 PM
lib/reducers/enabled-apps-reducer.js
35 ↗(On Diff #15649)

Yes, it is equal to true on web and undefined on native. This value is defined in webpack/shared.cjs and set in createProdBrowserConfig and createDevBrowserConfig.

This revision was automatically updated to reflect the committed changes.