Page MenuHomePhabricator
Differential D4895

[services] Blob - Fix Dockerfile
ClosedPublic
Actions

Authored by • karol on Aug 22 2022, 6:10 AM.
Tags
None
Referenced Files
F2176748: D4895.id15913.diff
Wed, Jul 3, 5:18 AM
F2176560: D4895.diff
Wed, Jul 3, 4:35 AM
Unknown Object (File)
Wed, Jun 26, 5:48 AM
Unknown Object (File)
Wed, Jun 26, 5:48 AM
Unknown Object (File)
Wed, Jun 26, 5:47 AM
Unknown Object (File)
Wed, Jun 26, 5:38 AM
Unknown Object (File)
Tue, Jun 25, 6:25 PM
Unknown Object (File)
Mon, Jun 24, 11:03 AM
View All 72 Files
Subscribers
• abosh
ashoat
atul
• jon
tomek

Details

Reviewers
• jon
marcin
tomek
Commits
rCOMM25f32c8b3729: [services] Blob - Fix Dockerfile
Summary

D4493 ruined building blob service using yarn scripts.

@jon Please, take a look here and let me know if this is a nix-friendly change.

Test Plan
cd services
yar run-backup-service-in-sandbox

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• karol created this revision.Aug 22 2022, 6:10 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptAug 22 2022, 6:10 AM
• karol edited the summary of this revision. (Show Details)Aug 22 2022, 6:14 AM
• karol edited the test plan for this revision. (Show Details)
• karol added reviewers: • jon, marcin, tomek.
• karol added a subscriber: • jon.
Harbormaster completed remote builds in B11497: Diff 15811.Aug 22 2022, 6:20 AM
• karol requested review of this revision.Aug 22 2022, 6:20 AM
marcin accepted this revision.Aug 22 2022, 6:33 AM
This revision is now accepted and ready to land.Aug 22 2022, 6:33 AM
ashoat added 1 blocking reviewer(s): • jon.Aug 22 2022, 7:14 PM
This revision now requires review to proceed.Aug 22 2022, 7:14 PM
• jon accepted this revision.EditedAug 23 2022, 8:40 AM

@jon Please, take a look here and let me know if this is a nix-friendly change.

Non-docker workflows (nix is just one) don't use docker, so I don't have an opinion. But the code looks fine.

D4493 ruined building blob service using yarn scripts.

We should probably have CI reflect this if it's the canonical way to build blob.

This revision is now accepted and ready to land.Aug 23 2022, 8:40 AM
• jon added a comment.Aug 23 2022, 9:02 AM

This also needs to be done for backup

$ yarn run-backup-service-in-sandbox
...
services-backup-server-1  | /bin/sh: 1: scripts/run_service.sh: not found
services-backup-server-1 exited with code 127
Done in 270.49s.

But that's a separate issue, and this still fixes a workflow.

Closed by commit rCOMM25f32c8b3729: [services] Blob - Fix Dockerfile (authored by • karol). · Explain WhyAug 24 2022, 4:17 AM
This revision was automatically updated to reflect the committed changes.
• karol added a commit: rCOMM25f32c8b3729: [services] Blob - Fix Dockerfile.
ashoat added a comment.Aug 24 2022, 9:09 AM

@jon, please don't ever point out an issue without creating or linking a task for it.

@karol, please don't ever land a diff where somebody has pointed out an issue without creating or linking a task or diff for it. Can you please do that now?

• jon added a comment.EditedAug 24 2022, 10:19 AM

@jon, please don't ever point out an issue without creating or linking a task for it.

I'm actually not sure who should have ownership of doing this. It was in the test plan, so everyone should have stumbled upon it.

Revision Contents
Changeset List

PathSize
services/
blob/
4 lines

Diff 15913

View Options

services/blob/Dockerfile

Loading...