Move development environment variable logic to a separate file.
This is to move more shell logic into files which can be checked with CI tools
for shell code.
Details
Details
- Reviewers
• abosh varun ashoat - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rCOMM45c89bdc1827: [Nix] Factor out dev env variable logic to another file
# Ensure you're not in a nix shell [[ -n "$IN_NIX_SHELL" ]] && exit nix develop echo "$MYSQL_UNIX_PORT" # points to something like "$HOME/.local/share/MariaDB/mysql.sock
- Shellcheck CI
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good.
| nix/dev-shell.nix | ||
|---|---|---|
| 103 ↗ | (On Diff #15843) | So the .. usually won't work at the beginning of the ${...} with ShellCheck, but since this is Nix, Nix will fill in the path of ../scripts/source_development_defaults.sh before shellHook is linted by ShellCheck, which is why it's ok? |
| nix/dev-shell.nix | ||
|---|---|---|
| 103 ↗ | (On Diff #15843) | correct, this is nix. So it will be source "/nix/store/<hash>-source_development_defaults.sh". when it runs. $ nix eval .#devShell.shellHook "# Set development environment variable defaults\nsource \"/nix/store/9b3x1bjcwjy0rz5rcdi5a8vgygxmdl33-source_development_defaults.sh\"\n\n# Provide decent bash prompt\nsource \"/nix/store/27ibqm60iqy0q8ksyxk83xr344wfv730-better-prompt/bin/better-prompt\"\n\necho \"Welcome to Comm dev environment! :)\"\n" The escaped output looks pretty bad, but you can see that there's just nix store paths.
shellHook isn't linted by shellCheck. writeShellApplication is a builder which will do this, but shellHook just gets evaluated. |
| 109–115 ↗ | (On Diff #15843) | The mariadb code here was added in https://phab.comm.dev/D4750. D4875 just extends the model to ensure mariadb is available every nix develop
This revision was done on master. Should I still specify D4750? (nix-shell) [08:34:15] jon@jon-desktop /home/jon/comm/comm (jonringer/move-shellhook-env-vars) $ git log --oneline --decorate | head -n 2 80476a736 (HEAD -> jonringer/move-shellhook-env-vars) [Nix] Factor out dev env variable logic to another file adf0b2a90 (tag: phabricator/base/15841, origin/master, origin/HEAD, master) [services] Tunnelbroker - Add FCM crate to Cargo dependencies |