[native] introduce generic for unexpected response handler
ClosedPublic
Actions

Authored by varun on Aug 22 2022, 9:09 PM.

Details

Reviewers

tomek
• karol
atul

Commits

rCOMMe46754ceabfd: [native] introduce generic for unexpected response handler

Summary

Since this function just logs the unexpected message and returns a gRPC Status, we can make it generic

Depends on D4904

Test Plan

cargo build (very small refactor)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 22 2022, 9:09 PM

Herald added subscribers: • abosh, ashoat. · View Herald TranscriptAug 22 2022, 9:09 PM

varun added a child revision: D4906: [native] helper functions for PAKE login workflow.Aug 22 2022, 9:10 PM

Harbormaster completed remote builds in B11523: Diff 15845.Aug 22 2022, 9:19 PM

varun requested review of this revision.Aug 22 2022, 9:19 PM

tomek accepted this revision.Aug 23 2022, 7:37 AM

This revision is now accepted and ready to land.Aug 23 2022, 7:37 AM

Closed by commit rCOMMe46754ceabfd: [native] introduce generic for unexpected response handler (authored by varun). · Explain WhyAug 23 2022, 8:45 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMe46754ceabfd: [native] introduce generic for unexpected response handler.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

grpc_client/

src/

lib.rs

10 lines

Diff 15873

View Options

native/cpp/CommonCpp/grpc/grpc_client/src/lib.rs

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines	render(): React.Node {

const textInputs = [];		const textInputs = [];
if (this.state.textInputKey > 0) {		if (this.state.textInputKey > 0) {
textInputs.push(		textInputs.push(
<TextInput		<TextInput
{...props}		{...props}
style={[props.style, styles.invisibleTextInput]}		style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText}		onChangeText={this.onOldInputChangeText}
		onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress}		onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur}		onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus}		onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1}		key={this.state.textInputKey - 1}
/>,		/>,
);		);
}		}
textInputs.push(		textInputs.push(
<TextInput		<TextInput
{...props}		{...props}
onFocus={this.onFocus}		onFocus={this.onFocus}
onBlur={this.onBlur}		onBlur={this.onBlur}
onChangeText={this.props.onChangeText}		onChangeText={this.props.onChangeText}
		onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey}		key={this.state.textInputKey}
ref={this.textInputRef}		ref={this.textInputRef}
/>,		/>,
);		);

return <View style={styles.textInputContainer}>{textInputs}</View>;		return <View style={styles.textInputContainer}>{textInputs}</View>;
}		}
}		}
Show All 12 Lines

[native] introduce generic for unexpected response handlerClosedPublicActions