Paths

Table of Contentst

Differential D4916

[web] Introduce `useMessageTooltipSidebarAction` hook
ClosedPublic
Actions

Authored by • jacek on Aug 23 2022, 5:00 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 6, 12:30 AM

	Unknown Object (File)
	Sun, Dec 1, 7:33 PM

	Unknown Object (File)
	Tue, Nov 26, 1:05 AM

	Unknown Object (File)
	Tue, Nov 26, 12:19 AM

	Unknown Object (File)
	Nov 22 2024, 8:27 AM

	Unknown Object (File)
	Nov 11 2024, 1:52 AM

	Unknown Object (File)
	Nov 7 2024, 4:20 PM

	Unknown Object (File)
	Nov 7 2024, 3:15 PM

Subscribers

Details

Reviewers

tomek
atul
• abosh

Commits

rCOMM928a05031726: [web] Introduce `useMessageTooltipSidebarAction` hook

Summary

Introduce tooltip action for "go to thread"/"create thread".

Test Plan

Flow; Tested with the rest of diffs stack.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jacek created this revision.Aug 23 2022, 5:00 AM

• jacek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2022, 5:00 AM

Harbormaster completed remote builds in B11534: Diff 15857.Aug 23 2022, 5:09 AM

• jacek added a parent revision: D4915: [web] Introduce `getMessageActionTooltipStyle` util function.Aug 23 2022, 5:27 AM

• jacek added a child revision: D4917: [web] Introduce `useMessageTooltipReplyAction` hook.

• jacek published this revision for review.Aug 23 2022, 8:06 AM

tomek requested changes to this revision.Aug 26 2022, 6:50 AM

tomek added inline comments.

web/chat/tooltip-utils.js
320–324 ↗	(On Diff #15857)	The names are confusing. The names suggest that these are functions that are called after a certain action was performed, e.g. `onThreadOpen` should be a function that is called after a thread was opened. But in our case, the intention is different and these functions perform the actions themself, so this should be just e.g. `openThread`.

This revision now requires changes to proceed.Aug 26 2022, 6:50 AM

• jacek added inline comments.Sep 1 2022, 3:35 AM

web/chat/tooltip-utils.js
320–324 ↗	(On Diff #15857)	Totally agree

address feedback

Harbormaster completed remote builds in B11791: Diff 16194.Sep 1 2022, 7:15 AM

tomek accepted this revision.Sep 2 2022, 3:06 AM

This revision is now accepted and ready to land.Sep 2 2022, 3:06 AM

Closed by commit rCOMM928a05031726: [web] Introduce `useMessageTooltipSidebarAction` hook (authored by • jacek). · Explain WhySep 5 2022, 3:13 AM

This revision was automatically updated to reflect the committed changes.

• jacek added a commit: rCOMM928a05031726: [web] Introduce `useMessageTooltipSidebarAction` hook.

Revision Contents
Changeset List

Path

Size

web/

chat/

tooltip-utils.js

47 lines

Diff 16292

web/chat/tooltip-utils.js

Loading...