Page MenuHomePhabricator
Differential D4923

[web] Remove old tooltip components
ClosedPublic
Actions

Authored by • jacek on Aug 23 2022, 5:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 29, 3:09 AM
Unknown Object (File)
Wed, Mar 26, 1:28 AM
Unknown Object (File)
Mon, Mar 24, 12:54 AM
Unknown Object (File)
Mon, Mar 17, 11:15 PM
Unknown Object (File)
Mon, Mar 17, 10:51 PM
Unknown Object (File)
Sun, Mar 16, 4:45 AM
Unknown Object (File)
Sun, Mar 16, 1:36 AM
Unknown Object (File)
Mon, Mar 10, 1:44 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
• abosh
Commits
rCOMMdbdac9d30be7: [web] Remove old tooltip components
Summary

Remove no longer used code related to tooltip.
At this point, only the new tooltip should be displayed.

The new component on the video:
https://linear.app/comm/issue/ENG-1575#comment-d3fe1db0

Test Plan

Tested the new tooltip on text, media and robotext messages with different sizes a location. Tested if all the actions work as before and the action list remains unchanged. The new tooltip should not cover inline sidebar if it exists.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jacek created this revision.Aug 23 2022, 5:17 AM
• jacek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 23 2022, 5:17 AM
Harbormaster completed remote builds in B11541: Diff 15864.Aug 23 2022, 5:26 AM
• jacek added a parent revision: D4922: [web] Remove timestamp tooltip from `ChatMessageList`.Aug 23 2022, 5:29 AM
• jacek added a child revision: D4924: [web] Redesign `InlineSidebar` with reactions support.
• jacek edited the summary of this revision. (Show Details)Aug 23 2022, 5:32 AM
• jacek published this revision for review.Aug 23 2022, 8:06 AM
tomek accepted this revision.Aug 26 2022, 9:36 AM

Tested if all the actions work as before.

Have you tested if the set of actions is exactly the same as before?

This revision is now accepted and ready to land.Aug 26 2022, 9:36 AM
• jacek edited the test plan for this revision. (Show Details)Sep 1 2022, 6:21 AM
• jacek edited the test plan for this revision. (Show Details)
In D4923#143832, @tomek wrote:

Tested if all the actions work as before.

Have you tested if the set of actions is exactly the same as before?

Yes, I've checked it

• jacek updated this revision to Diff 16202.Sep 1 2022, 7:16 AM

rebase

Harbormaster completed remote builds in B11799: Diff 16202.Sep 1 2022, 7:26 AM
Closed by commit rCOMMdbdac9d30be7: [web] Remove old tooltip components (authored by • jacek). · Explain WhySep 5 2022, 3:13 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMMdbdac9d30be7: [web] Remove old tooltip components.

Revision Contents
Changeset List

Diff 16299

View Options

web/chat/message-reply-button.react.js

  • This file was added.
// 400KiB limit (in docs there is KB but they mean KiB) -
// https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/ServiceQuotas.html
// This includes both attribute names' and values' lengths
pub const DDB_ITEM_SIZE_LIMIT: usize = 1024 * 400;
// 4MB limit
// WARNING: use keeping in mind that grpc adds its own headers to messages
// https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
// so the message that actually is being sent over the network looks like this
// [Compressed-Flag] [Message-Length] [Message]
// [Compressed-Flag] 1 byte - added by grpc
// [Message-Length] 4 bytes - added by grpc
// [Message] N bytes - actual data
// so for every message we get 5 additional bytes of data
// as mentioned here
// https://github.com/grpc/grpc/issues/15734#issuecomment-396962671
// grpc stream may contain more than one message
pub const GRPC_CHUNK_SIZE_LIMIT: usize = 4 * 1024 * 1024;
pub const GRPC_METADATA_SIZE_PER_MESSAGE: usize = 5;
View Options

web/chat/message-timestamp-tooltip.css

  • This file was added.
// 400KiB limit (in docs there is KB but they mean KiB) -
// https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/ServiceQuotas.html
// This includes both attribute names' and values' lengths
pub const DDB_ITEM_SIZE_LIMIT: usize = 1024 * 400;
// 4MB limit
// WARNING: use keeping in mind that grpc adds its own headers to messages
// https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
// so the message that actually is being sent over the network looks like this
// [Compressed-Flag] [Message-Length] [Message]
// [Compressed-Flag] 1 byte - added by grpc
// [Message-Length] 4 bytes - added by grpc
// [Message] N bytes - actual data
// so for every message we get 5 additional bytes of data
// as mentioned here
// https://github.com/grpc/grpc/issues/15734#issuecomment-396962671
// grpc stream may contain more than one message
pub const GRPC_CHUNK_SIZE_LIMIT: usize = 4 * 1024 * 1024;
pub const GRPC_METADATA_SIZE_PER_MESSAGE: usize = 5;
View Options

web/chat/message-timestamp-tooltip.react.js

  • This file was added.
// 400KiB limit (in docs there is KB but they mean KiB) -
// https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/ServiceQuotas.html
// This includes both attribute names' and values' lengths
pub const DDB_ITEM_SIZE_LIMIT: usize = 1024 * 400;
// 4MB limit
// WARNING: use keeping in mind that grpc adds its own headers to messages
// https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
// so the message that actually is being sent over the network looks like this
// [Compressed-Flag] [Message-Length] [Message]
// [Compressed-Flag] 1 byte - added by grpc
// [Message-Length] 4 bytes - added by grpc
// [Message] N bytes - actual data
// so for every message we get 5 additional bytes of data
// as mentioned here
// https://github.com/grpc/grpc/issues/15734#issuecomment-396962671
// grpc stream may contain more than one message
pub const GRPC_CHUNK_SIZE_LIMIT: usize = 4 * 1024 * 1024;
pub const GRPC_METADATA_SIZE_PER_MESSAGE: usize = 5;
View Options

web/chat/tooltip-utils.js

  • This file was added.
// 400KiB limit (in docs there is KB but they mean KiB) -
// https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/ServiceQuotas.html
// This includes both attribute names' and values' lengths
pub const DDB_ITEM_SIZE_LIMIT: usize = 1024 * 400;
// 4MB limit
// WARNING: use keeping in mind that grpc adds its own headers to messages
// https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
// so the message that actually is being sent over the network looks like this
// [Compressed-Flag] [Message-Length] [Message]
// [Compressed-Flag] 1 byte - added by grpc
// [Message-Length] 4 bytes - added by grpc
// [Message] N bytes - actual data
// so for every message we get 5 additional bytes of data
// as mentioned here
// https://github.com/grpc/grpc/issues/15734#issuecomment-396962671
// grpc stream may contain more than one message
pub const GRPC_CHUNK_SIZE_LIMIT: usize = 4 * 1024 * 1024;
pub const GRPC_METADATA_SIZE_PER_MESSAGE: usize = 5;
View Options

web/chat/tooltip.css

  • This file was added.
// 400KiB limit (in docs there is KB but they mean KiB) -
// https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/ServiceQuotas.html
// This includes both attribute names' and values' lengths
pub const DDB_ITEM_SIZE_LIMIT: usize = 1024 * 400;
// 4MB limit
// WARNING: use keeping in mind that grpc adds its own headers to messages
// https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md
// so the message that actually is being sent over the network looks like this
// [Compressed-Flag] [Message-Length] [Message]
// [Compressed-Flag] 1 byte - added by grpc
// [Message-Length] 4 bytes - added by grpc
// [Message] N bytes - actual data
// so for every message we get 5 additional bytes of data
// as mentioned here
// https://github.com/grpc/grpc/issues/15734#issuecomment-396962671
// grpc stream may contain more than one message
pub const GRPC_CHUNK_SIZE_LIMIT: usize = 4 * 1024 * 1024;
pub const GRPC_METADATA_SIZE_PER_MESSAGE: usize = 5;
View Options

web/chat/tooltip.react.js

Loading...