Page MenuHomePhabricator

Revert "[landing] SIWE component with RainbowKit that connects & signs a message"
ClosedPublic

Authored by derek on Aug 27 2022, 10:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 1:51 AM
Unknown Object (File)
Sun, Nov 10, 2:52 PM
Unknown Object (File)
Sat, Nov 9, 6:45 AM
Unknown Object (File)
Sat, Nov 9, 6:44 AM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:07 AM
Unknown Object (File)
Mon, Oct 28, 5:05 AM
Unknown Object (File)
Fri, Oct 25, 4:59 PM

Details

Summary

This reverts commit 4dd1bf70caab7877a3c7b9108fbdbc3c90b24952 (SIWE) while we get to the bottom of the cool looking issue caused by rainbowkit
video:
relevant context:

image.png (816×1 px, 2 MB)

Test Plan

ran it before reverting and after. fixes CSS issue

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 27 2022, 10:49 AM
Harbormaster failed remote builds in B11662: Diff 16036!

Looks like the Android CI is failing here. Please don't request review (manually, by submitting an action) if the CI is failing unless you have a good reason. I've restarted the Android CI build to see if it passes again, but Phabricator automatically adds a "Changes Planned" action to your diff if any builds fail. When you request review manually, the Changes Planned tag gets overwritten by the Needs Review tag. But this isn't great, because if the CI is failing, your code can't be landed as-is (unless there's a good reason). So any review is probably unnecessary if the builds fail. Changes Planned removes the diff from reviewers' queues until the CI can pass again.

This revision now requires changes to proceed.Aug 27 2022, 10:59 AM

requesting review because builds passed 🫡

Awesome! Can probably land this since all the builds passed.

This revision is now accepted and ready to land.Aug 27 2022, 11:02 AM