Page MenuHomePhabricator

[Native] Cleanup Tools/CMakeLists.txt
ClosedPublic

Authored by jon on Aug 30 2022, 2:54 PM.
Tags
None
Referenced Files
F3358687: D4987.diff
Sun, Nov 24, 5:47 AM
Unknown Object (File)
Sat, Nov 16, 4:09 AM
Unknown Object (File)
Wed, Nov 13, 6:07 AM
Unknown Object (File)
Sun, Oct 27, 6:50 AM
Unknown Object (File)
Oct 23 2024, 10:02 AM
Unknown Object (File)
Oct 23 2024, 10:02 AM
Unknown Object (File)
Oct 23 2024, 10:02 AM
Unknown Object (File)
Oct 22 2024, 4:49 PM
Subscribers

Details

Summary

When adding the the CMakeLists.txt, I wasn't able to
reference the other sibling projects. This change is to remove
the target_include_directories entries in favor
of using target_link_library which is the more canonical way
to reference other projects now that they exist.

Depends on D4986

Test Plan
nix develop
cd native/cpp/CommonCpp
rm -rf build && mkdir build && cd build && cmake .. && make -j

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cd native/cpp/CommonCpp

Guessing this was supposed to be native/cpp/CommonCpp/Tools?

Nice (assuming it was supposed to be within Tools)!

atuls-MacBook-Pro:build atul$ make -j
[ 50%] Building CXX object CMakeFiles/comm-tools.dir/WorkerThread.cpp.o
[100%] Linking CXX static library libcomm-tools.a
[100%] Built target comm-tools
This revision is now accepted and ready to land.Aug 30 2022, 3:21 PM

Nice (assuming it was supposed to be within Tools)!

CommonCpp was correct. The individual projects need to reference each other, and the parent directory is the correct place to do so. Tools just happens to be the only leaf.

This revision was automatically updated to reflect the committed changes.