[web] Group usernames case insensitively in `MembersList`
ClosedPublic
Actions

Authored by • abosh on Sep 1 2022, 1:36 AM.

Details

Reviewers

tomek
atul
inka

Commits

rCOMMd3e08bf50142: [web] Group usernames case insensitively in `MembersList`

Summary

Related Linear issue here.

Aboshcapital, aboshlocal, and Ashoatcapital's names all start with the letter A, but two groupings are created because the case is different. This diff merges the two groups together and groups member usernames case insensitively.

Test Plan

Tested on Chrome/Safari and works as expected.

Before:

After:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• abosh created this revision.Sep 1 2022, 1:36 AM

Herald added a subscriber: ashoat. · View Herald TranscriptSep 1 2022, 1:36 AM

• abosh edited the summary of this revision. (Show Details)Sep 1 2022, 1:38 AM

• abosh edited the test plan for this revision. (Show Details)

• abosh edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B11755: Diff 16156.Sep 1 2022, 1:45 AM

• abosh requested review of this revision.Sep 1 2022, 1:45 AM

good catch, wonder if there are any other places in the codebase where this is an issue

This revision is now accepted and ready to land.Sep 1 2022, 11:50 AM

Closed by commit rCOMMd3e08bf50142: [web] Group usernames case insensitively in `MembersList` (authored by • abosh). · Explain WhySep 1 2022, 6:11 PM

This revision was automatically updated to reflect the committed changes.

• abosh added a commit: rCOMMd3e08bf50142: [web] Group usernames case insensitively in `MembersList`.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

members-list.react.js

3 lines

Diff 16216

View Options

web/modals/threads/members/members-list.react.js

[web] Group usernames case insensitively in `MembersList`ClosedPublicActions