Page MenuHomePhabricator
Differential D5111

[web] Add box shadow to message tooltips
ClosedPublic
Actions

Authored by ginsu on Sep 12 2022, 6:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 3:03 PM
Unknown Object (File)
Fri, Nov 8, 3:03 PM
Unknown Object (File)
Fri, Nov 8, 3:03 PM
Unknown Object (File)
Fri, Nov 8, 3:01 PM
Unknown Object (File)
Fri, Nov 8, 2:59 PM
Unknown Object (File)
Oct 19 2024, 6:01 PM
Unknown Object (File)
Oct 11 2024, 2:15 PM
Unknown Object (File)
Oct 8 2024, 8:14 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
• abosh
Commits
rCOMM088c3d06da34: [web] Add box shadow to message tooltips
Summary

Added box shadow to message timestamp tooltip and message tooltip components. The changes are subtle but they definitely make the tooltips "pop" more

Test Plan

Please view the screenshots to see the before and after of the changes I made:

Before:

Screen Shot 2022-09-12 at 10.30.45 PM.png (676×1 px, 223 KB)

After:

Screen Shot 2022-09-12 at 10.30.10 PM.png (626×1 px, 223 KB)

Diff Detail

Repository
rCOMM Comm
Branch
eng-1525
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Sep 12 2022, 6:37 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 12 2022, 6:37 AM
ginsu edited the test plan for this revision. (Show Details)Sep 12 2022, 6:38 AM
ginsu added a reviewer: atul.
ginsu attached a referenced file: F166889: Screen Shot 2022-09-12 at 10.30.10 PM.png. (Show Details)
ginsu attached a referenced file: F166888: Screen Shot 2022-09-12 at 10.30.45 PM.png. (Show Details)
Harbormaster completed remote builds in B12081: Diff 16582.Sep 12 2022, 6:47 AM
ginsu requested review of this revision.Sep 12 2022, 6:47 AM
atul retitled this revision from [web] added box shawdow to message tooltips to [web] Add box shadow to message tooltips.Sep 12 2022, 10:28 AM
atul edited the summary of this revision. (Show Details)Sep 12 2022, 10:39 AM
atul edited the summary of this revision. (Show Details)
atul accepted this revision.Sep 12 2022, 10:41 AM

Looks good!

This revision is now accepted and ready to land.Sep 12 2022, 10:41 AM
• abosh accepted this revision.Sep 12 2022, 11:20 AM

D4343, but looks good otherwise!

web/chat/message-tooltip.css
16
49
ginsu updated this revision to Diff 16621.Sep 13 2022, 7:49 AM

resoved aboshs comments

Harbormaster completed remote builds in B12113: Diff 16621.Sep 13 2022, 8:00 AM
Closed by commit rCOMM088c3d06da34: [web] Add box shadow to message tooltips (authored by ginsu). · Explain WhySep 15 2022, 12:18 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM088c3d06da34: [web] Add box shadow to message tooltips.

Revision Contents
Changeset List

PathSize
web/
chat/
2 lines

Diff 16582

View Options

web/chat/message-tooltip.css

Loading...