Page MenuHomePhabricator
Differential D5140

[web] introduced icons for relationship action buttons
ClosedPublic
Actions

Authored by ginsu on Sep 14 2022, 10:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 6:05 AM
Unknown Object (File)
Sun, Nov 10, 1:51 AM
Unknown Object (File)
Sun, Nov 10, 12:11 AM
Unknown Object (File)
Sat, Nov 9, 9:12 PM
Unknown Object (File)
Sat, Nov 9, 3:46 PM
Unknown Object (File)
Oct 10 2024, 6:11 AM
Unknown Object (File)
Oct 10 2024, 6:11 AM
Unknown Object (File)
Oct 10 2024, 6:10 AM
View All 77 Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
• abosh
Commits
rCOMM82d4b560b3a3: [web] introduced icons for relationship action buttons
Summary

The buttons in the relationship chat settings now have colors that are consistent with the other relationship prompt buttons found in the app.

Depends on D5100

Test Plan

Please view the screenshots to see the before and after of the changes I made

Before:

Screen Shot 2022-09-14 at 11.08.24 PM.png (938×868 px, 51 KB)

After:
Add friend and block case:

Screen Shot 2022-09-15 at 2.17.48 PM.png (890×798 px, 49 KB)

Withdraw friend request case:

Screen Shot 2022-09-15 at 2.17.58 PM.png (898×828 px, 59 KB)

Accept and reject friend request case:

Screen Shot 2022-09-15 at 2.19.02 PM.png (822×850 px, 65 KB)

unfriend case:

Screen Shot 2022-09-15 at 2.19.07 PM.png (882×786 px, 42 KB)

unblock case:

Screen Shot 2022-09-15 at 2.18.28 PM.png (902×818 px, 44 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 14 2022, 10:15 PM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 14 2022, 10:15 PM
ginsu edited the summary of this revision. (Show Details)Sep 14 2022, 10:21 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu added a parent revision: D5100: [web] Introduce colors for relationship action buttons.
ginsu attached a referenced file: F169712: Screen Shot 2022-09-15 at 2.18.28 PM.png. (Show Details)
ginsu attached a referenced file: F169711: Screen Shot 2022-09-15 at 2.19.07 PM.png. (Show Details)
ginsu attached a referenced file: F169710: Screen Shot 2022-09-15 at 2.19.02 PM.png. (Show Details)
ginsu attached a referenced file: F169709: Screen Shot 2022-09-15 at 2.17.58 PM.png. (Show Details)
ginsu attached a referenced file: F169708: Screen Shot 2022-09-15 at 2.17.48 PM.png. (Show Details)
ginsu attached a referenced file: F169707: Screen Shot 2022-09-14 at 11.08.24 PM.png. (Show Details)
Harbormaster completed remote builds in B12154: Diff 16681.Sep 14 2022, 10:25 PM
ginsu requested review of this revision.Sep 14 2022, 10:25 PM
ginsu retitled this revision from introduced icons for relationship action buttons to [web] introduced icons for relationship action buttons.Sep 14 2022, 10:40 PM
atul added 1 blocking reviewer(s): atul.Sep 15 2022, 7:39 AM
atul accepted this revision.Sep 15 2022, 8:43 AM
atul added a reviewer: • abosh.

Looks good!

This revision is now accepted and ready to land.Sep 15 2022, 8:44 AM
Closed by commit rCOMM82d4b560b3a3: [web] introduced icons for relationship action buttons (authored by ginsu). · Explain WhySep 16 2022, 12:50 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM82d4b560b3a3: [web] introduced icons for relationship action buttons.

Revision Contents
Changeset List

Diff 16731

View Options

web/modals/threads/settings/thread-settings-relationship-button.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-relationship-tab.css

Loading...