Page MenuHomePhabricator
Differential D5141

[web] add ellipsis icon to the left of the "see more..." text
ClosedPublic
Actions

Authored by ginsu on Sep 14 2022, 11:52 PM.
Tags
None
Referenced Files
F3525610: D5141.diff
Mon, Dec 23, 5:55 PM
Unknown Object (File)
Sat, Dec 21, 11:52 PM
Unknown Object (File)
Thu, Dec 12, 2:17 AM
Unknown Object (File)
Nov 11 2024, 2:51 AM
Unknown Object (File)
Nov 2 2024, 1:15 PM
Unknown Object (File)
Nov 2 2024, 1:15 PM
Unknown Object (File)
Nov 2 2024, 1:15 PM
Unknown Object (File)
Nov 2 2024, 1:12 PM
View All 65 Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
Commits
rCOMM57be50092093: [web] add ellipsis icon to the left of the "see more..." text
Summary

add ellipsis icon to the left of the "see more..." text in the ChatThreadListSeeMoreSidebars component using the ionicons icon pack

Depends on D5108

Test Plan

Please view the screenshots to see the before and after of the changes I made

Before:

Screen Shot 2022-09-15 at 3.56.38 PM.png (798×894 px, 69 KB)

After:

Screen Shot 2022-09-15 at 3.56.57 PM.png (784×860 px, 67 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Sep 14 2022, 11:52 PM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 14 2022, 11:52 PM
ginsu retitled this revision from [web] add ellipsis icon to the left of the "see more" text to [web] add ellipsis icon to the left of the "see more..." text.Sep 14 2022, 11:55 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added a reviewer: atul.
ginsu edited the summary of this revision. (Show Details)Sep 14 2022, 11:58 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added a parent revision: D5108: [web] Added `react-icons` dependency to `web`.
Harbormaster completed remote builds in B12156: Diff 16683.Sep 15 2022, 12:01 AM
ginsu requested review of this revision.Sep 15 2022, 12:01 AM
ginsu attached a referenced file: F169791: Screen Shot 2022-09-15 at 3.56.57 PM.png. (Show Details)Sep 15 2022, 12:02 AM
ginsu attached a referenced file: F169790: Screen Shot 2022-09-15 at 3.56.38 PM.png. (Show Details)
atul added 1 blocking reviewer(s): atul.Sep 15 2022, 7:39 AM
atul requested changes to this revision.Sep 20 2022, 2:15 PM

Super close! Let's just use px units instead of em for size to keep things consistent with other icons.

web/chat/chat-thread-list-see-more-sidebars.react.js
42 ↗(On Diff #16683)

Nit: We usually use px units for icon sizes. Once you make that change this diff should be good to go.

This revision now requires changes to proceed.Sep 20 2022, 2:15 PM
ginsu updated this revision to Diff 16936.Sep 20 2022, 8:43 PM

converted em to px

Harbormaster completed remote builds in B12338: Diff 16936.Sep 20 2022, 8:53 PM
atul accepted this revision.Sep 21 2022, 5:28 AM
This revision is now accepted and ready to land.Sep 21 2022, 5:28 AM
Closed by commit rCOMM57be50092093: [web] add ellipsis icon to the left of the "see more..." text (authored by ginsu). · Explain WhySep 21 2022, 10:12 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM57be50092093: [web] add ellipsis icon to the left of the "see more..." text.

Revision Contents
Changeset List

Diff 16971

View Options

web/chat/chat-thread-list-see-more-sidebars.react.js

Loading...
View Options

web/chat/chat-thread-list.css

Loading...