Paths

Table of Contentst

Differential D5163

[CI] Add identity tests to github actions
ClosedPublic
Actions

Authored by • jon on Sep 16 2022, 10:51 AM.

Tags

None

Referenced Files

	F3282391: D5163.diff
	Sat, Nov 16, 10:58 AM

	Unknown Object (File)
	Sat, Nov 9, 7:37 PM

	Unknown Object (File)
	Sat, Nov 9, 7:37 PM

	Unknown Object (File)
	Sat, Nov 9, 7:37 PM

	Unknown Object (File)
	Sat, Nov 9, 7:37 PM

	Unknown Object (File)
	Fri, Nov 8, 8:34 AM

	Unknown Object (File)
	Tue, Nov 5, 2:07 AM

	Unknown Object (File)
	Oct 16 2024, 11:29 PM

Subscribers

Details

Reviewers

atul
ashoat

Commits

rCOMM953c2fd9f04c: [CI] Add identity tests to github actions

Summary

Add identity tests to github

https://linear.app/comm/issue/ENG-1470

Test Plan

https://github.com/CommE2E/comm/actions/runs/3069899201/jobs/4959060294 passes

Diff Detail

Repository

Branch

jonringer/github-identity-tests

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jon created this revision.Sep 16 2022, 10:51 AM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptSep 16 2022, 10:51 AM

Harbormaster completed remote builds in B12223: Diff 16771.Sep 16 2022, 11:01 AM

• jon requested review of this revision.Sep 16 2022, 11:01 AM

• jon planned changes to this revision.Sep 16 2022, 11:11 AM

Use cachix/install-nix and use our comm cache

• jon edited the test plan for this revision. (Show Details)Sep 16 2022, 11:36 AM

Harbormaster completed remote builds in B12225: Diff 16773.Sep 16 2022, 11:45 AM

Looks good!

Adding @ashoat as blocking since this (kind of) introduces a dependency on cachix/install-nix-action@v17 (https://github.com/cachix/install-nix-action).. though I'm fairly confident it's fine.

.github/workflows/identity_tests.yml
19 ↗	(On Diff #16773)	Guessing that there's no downside to having this key checked in?

• jon marked an inline comment as done.Sep 19 2022, 3:43 PM

• jon added inline comments.

.github/workflows/identity_tests.yml
19 ↗	(On Diff #16773)	Correct, it's just a public key. This also might be unnecessary with https://phab.comm.dev/D5183

ashoat accepted this revision.Sep 20 2022, 4:46 AM

This revision is now accepted and ready to land.Sep 20 2022, 4:46 AM

Apply --accept-flake-config fixes, run if nix files change

Harbormaster completed remote builds in B12328: Diff 16920.Sep 20 2022, 9:50 AM

Closed by commit rCOMM953c2fd9f04c: [CI] Add identity tests to github actions (authored by • jon). · Explain WhySep 20 2022, 12:40 PM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM953c2fd9f04c: [CI] Add identity tests to github actions.

Revision Contents
Changeset List

Path

Size

.github/

workflows/

identity_tests.yml

18 lines

Diff 16771

.github/workflows/identity_tests.yml

Loading...