Page MenuHomePhabricator
Differential D5165

[services] Tunnelbroker - Add `updateSessionItemIsOnline` database method
ClosedPublic
Actions

Authored by • max on Sep 16 2022, 11:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 5, 1:59 PM
Unknown Object (File)
Mon, Mar 31, 5:11 PM
Unknown Object (File)
Fri, Mar 21, 11:17 PM
Unknown Object (File)
Mon, Mar 17, 4:19 AM
Unknown Object (File)
Mon, Mar 17, 4:19 AM
Unknown Object (File)
Mon, Mar 17, 4:19 AM
Unknown Object (File)
Mon, Mar 17, 4:18 AM
Unknown Object (File)
Sat, Mar 15, 8:04 PM
View All Files
Subscribers
• abosh
ashoat
atul
• karol
tomek

Details

Reviewers
• jon
tomek
• karol
Commits
rCOMMe4f0d2ebe260: [services] Tunnelbroker - Add `updateSessionItemIsOnline` database method
Summary

This diff introduces adding of updateSessionItemIsOnline database method.

To send notifications if the device is offline we need to distinguish the device state. To do this we will ping the device and change the device status (online/offline) in the IsOnline field (D5164) using the introduced method.

More context is available in the Linear task description.

Related Linear task: ENG-1766

Test Plan
  1. Successfully built.
  2. Passed a unit test in D5166.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Sep 16 2022, 11:51 AM
• max held this revision as a draft.
Herald added a reviewer: • jon. · View Herald TranscriptSep 16 2022, 11:51 AM
Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald Transcript
• max added a parent revision: D5164: [services] Tunnelbroker - Update `SessionItem` database entity with the `IsOnline` field.Sep 16 2022, 11:51 AM
Harbormaster completed remote builds in B12227: Diff 16775.Sep 16 2022, 11:59 AM
• max added a child revision: D5166: [services] Tunnelbroker - Add test for the `updateSessionItemIsOnline` database method.Sep 16 2022, 12:08 PM
• max edited the summary of this revision. (Show Details)Sep 16 2022, 12:21 PM
• max edited the test plan for this revision. (Show Details)
• max added a reviewer: tomek.
• max published this revision for review.Sep 16 2022, 12:25 PM
• max mentioned this in D5166: [services] Tunnelbroker - Add test for the `updateSessionItemIsOnline` database method.
Herald added a reviewer: • karol. · View Herald TranscriptSep 16 2022, 12:26 PM
• max added a child revision: D5175: [services] Tunnelbroker - Update device online status in `Get` handler.Sep 19 2022, 5:58 AM
tomek accepted this revision.Sep 19 2022, 6:02 AM
tomek added inline comments.
services/tunnelbroker/src/Database/DatabaseManager.cpp
109–110 ↗(On Diff #16775)

We're not updating checkpoint time

This revision is now accepted and ready to land.Sep 19 2022, 6:02 AM
• max marked an inline comment as done.Sep 19 2022, 6:03 AM
• max added inline comments.
services/tunnelbroker/src/Database/DatabaseManager.cpp
109–110 ↗(On Diff #16775)

We're not updating checkpoint time

Wow, sorry about that. I'll fix this. Thanks @tomek ;)

• max mentioned this in D5173: [services] Tunnelbroker - Update Protobuf file with the `ping`.Sep 19 2022, 6:32 AM
• max mentioned this in D5174: [services] Tunnelbroker - Add ping implementation to the `Get` handler.Sep 19 2022, 6:35 AM
• max updated this revision to Diff 16899.Sep 20 2022, 5:44 AM
• max marked an inline comment as done.

Rebased on parent changes. Error message was fixed.

Harbormaster failed remote builds in B12311: Diff 16899!Sep 20 2022, 5:45 AM
Harbormaster completed remote builds in B12311: Diff 16899.Sep 20 2022, 5:57 AM
Closed by commit rCOMMe4f0d2ebe260: [services] Tunnelbroker - Add `updateSessionItemIsOnline` database method (authored by • max). · Explain WhySep 20 2022, 6:19 AM
This revision was automatically updated to reflect the committed changes.
• max added a commit: rCOMMe4f0d2ebe260: [services] Tunnelbroker - Add `updateSessionItemIsOnline` database method.
• max mentioned this in rCOMMf6cc2d93dede: [services] Tunnelbroker - Add test for the `updateSessionItemIsOnline` database….
• max removed a child revision: D5175: [services] Tunnelbroker - Update device online status in `Get` handler.Sep 20 2022, 6:21 AM
• max mentioned this in rCOMMbf9ad730ef50: [services] Tunnelbroker - Update Protobuf file with the `ping`.Sep 21 2022, 2:29 PM
• max mentioned this in rCOMM5d2497b42072: [services] Tunnelbroker - Add ping implementation to the `Get` handler.Sep 23 2022, 1:51 PM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
Database/
3 lines
39 lines

Diff 16905

View Options

services/tunnelbroker/src/Database/DatabaseManager.h

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines networks:
- services-net - services-net
build: build:
dockerfile: services/identity/Dockerfile dockerfile: services/identity/Dockerfile
context: ../ context: ../
image: commapp/identity-server:0.1 image: commapp/identity-server:0.1
container_name: identity-server container_name: identity-server
ports: ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051" - "${COMM_SERVICES_PORT_IDENTITY}:50051"
# localstack
localstack:
image: localstack/localstack
container_name: localstack
hostname: localstack
ports:
- "4566:4566"
environment:
- SERVICES=s3,dynamodb
- DATA_DIR=${TMPDIR}/localstack/data
- HOSTNAME_EXTERNAL=localstack
volumes:
jimUnsubmitted
Not Done
Inline Actions

Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.

jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
- ${TMPDIR}:/tmp/localstack
networks:
- services-net
View Options

services/tunnelbroker/src/Database/DatabaseManager.cpp

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines networks:
- services-net - services-net
build: build:
dockerfile: services/identity/Dockerfile dockerfile: services/identity/Dockerfile
context: ../ context: ../
image: commapp/identity-server:0.1 image: commapp/identity-server:0.1
container_name: identity-server container_name: identity-server
ports: ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051" - "${COMM_SERVICES_PORT_IDENTITY}:50051"
# localstack
localstack:
image: localstack/localstack
container_name: localstack
hostname: localstack
ports:
- "4566:4566"
environment:
- SERVICES=s3,dynamodb
- DATA_DIR=${TMPDIR}/localstack/data
- HOSTNAME_EXTERNAL=localstack
volumes:
jimUnsubmitted
Not Done
Inline Actions

Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.

jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
- ${TMPDIR}:/tmp/localstack
networks:
- services-net