[web] Changed non-viewer blockquote message container color to be the base thread color
AbandonedPublic
Actions

Authored by ginsu on Sep 19 2022, 7:01 AM.

Details

Reviewers

atul
ashoat

Summary

In the past there was no distinction between blockquote container color if non-viewer or viewer; changed non-viewer blockquote message container to be the base thread color as discussed in linear

Linear issue: ENG-1712.
Depends on D4999

Test Plan

Please view the screenshots to see the before and after of the changes I made:

Before:

After:

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D4999 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Sep 19 2022, 7:01 AM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptSep 19 2022, 7:01 AM

ginsu edited the summary of this revision. (Show Details)Sep 19 2022, 7:06 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, ashoat.

ginsu added a parent revision: D4999: [web] Implement darker thread color tint to blockquote container.

ginsu attached a referenced file: F174156: Screen Shot 2022-09-19 at 11.05.31 PM.png. (Show Details)

ginsu attached a referenced file: F174155: Screen Shot 2022-09-19 at 11.05.05 PM.png. (Show Details)

Harbormaster completed remote builds in B12274: Diff 16836.Sep 19 2022, 7:12 AM

ginsu requested review of this revision.Sep 19 2022, 7:12 AM

Is there some way to design this so that we don't have to pass in this info? Can we use opacity layers or something to make the blockquote appear appropriate for both viewer / non-viewer cases? Or maybe there is some way in CSS to do a calc based on an inherited way or something? Probably will be harder on native, but seems likely that this can be done on web...