Page MenuHomePhabricator

[web] Clear error message during switching between tabs in `ThreadSettingsModal`
ClosedPublic

Authored by jakub on Sep 23 2022, 7:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 20, 4:39 AM
Unknown Object (File)
Fri, Jan 20, 4:39 AM
Unknown Object (File)
Fri, Jan 20, 4:39 AM
Unknown Object (File)
Fri, Jan 20, 4:39 AM
Unknown Object (File)
Fri, Jan 20, 4:39 AM
Unknown Object (File)
Thu, Jan 19, 11:45 PM
Unknown Object (File)
Dec 6 2022, 6:58 PM
Unknown Object (File)
Dec 6 2022, 6:58 PM

Details

Summary

Depends on D5220

Improving UX of the ThreadSettingsModal

Main change:

  • clear error message when current active tab changes

Test Plan
  1. Go to any chat
  2. Go to Thread Menu > Settings (ThreadSettingsModal)
  3. Trigger any error (e.g. type wrong password in Delete tab)
  4. Switch to another tab

Now error message disappear

Diff Detail

Repository
rCOMM Comm
Branch
jakub/settings-modal-adjustments
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul added 1 blocking reviewer(s): tomek.

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

In D5222#153960, @atul wrote:

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

Yeah, sounds like a good idea. We should create a new task for it and implement it when appropriate. @jakub could you create a task?

web/modals/threads/settings/thread-settings-modal.react.js
127

For me it would make a little more sense to clear on exit instead of enter

This revision is now accepted and ready to land.Sep 27 2022, 4:50 AM

Adjust to code review and rebase

In D5222#154090, @tomek wrote:
In D5222#153960, @atul wrote:

Based on the video you provided, should we also gray out the Delete button in the Delete tab if the password input field is empty?

Yeah, sounds like a good idea. We should create a new task for it and implement it when appropriate. @jakub could you create a task?

Sure, I've just created it: link