This diff refactors previous union type LoginActionSource and scattered constants with actions to frequently used pattern with the frozen object to maintain a single source of truth for actions.
Other than that, it'll make validation of this field easier while passing it to the keyserver (introduced in next diffs).
Details
Details
Run type checks to make sure ale usages were properly updated.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/account-utils.js | ||
|---|---|---|
| 3–4 ↗ | (On Diff #17077) | Can we merge these into a single import? |
| lib/socket/socket.react.js | ||
| 16–17 ↗ | (On Diff #17077) | Merge these |
| lib/types/account-types.js | ||
| 77 ↗ | (On Diff #17077) | Not really sure if adding types at the end is beneficial. I guess loginActionSources would suffice but might be wrong. |
| 88 ↗ | (On Diff #17077) | I think it will be more readable when we use singular form here |