Page MenuHomePhabricator

[native] Fix bitcode issue with Xcode 14
ClosedPublic

Authored by ashoat on Oct 1 2022, 5:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 3:17 AM
Unknown Object (File)
Mon, Oct 28, 5:09 AM
Unknown Object (File)
Mon, Oct 28, 5:09 AM
Unknown Object (File)
Mon, Oct 28, 5:06 AM
Unknown Object (File)
Oct 12 2024, 11:28 AM
Unknown Object (File)
Oct 10 2024, 7:58 AM
Unknown Object (File)
Oct 10 2024, 7:33 AM
Unknown Object (File)
Oct 4 2024, 9:54 PM
Subscribers

Details

Summary

Addresses ENG-1938. Learned more about this issue here.

This diff effectively reverts D30. Back then, the default was ENABLE_BITCODE = YES, and that diff had the effect of disabling bitcode for debug builds. Now that ENABLE_BITCODE = NO is the default, that diff has the effect of enabling bitcode for release builds.

Deleting these lines puts us back to "default" behavior, which is now to have bitcode disabled.

Test Plan

Issue no longer occurs after yarn workspace native clean-all && yarn cleaninstall

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage