[landing] added classnames dependency
ClosedPublic
Actions

Authored by ginsu on Oct 10 2022, 1:53 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMMd5c68d051664: [landing] added classnames dependency

Summary

added classnames dependency. This is so that we can use add conditional logic to Investor Profile Card Modal classes. We use this in the web codebase

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Oct 10 2022, 1:53 PM

Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptOct 10 2022, 1:53 PM

ginsu edited the summary of this revision. (Show Details)Oct 10 2022, 1:55 PM

ginsu added reviewers: ashoat, atul.

ginsu edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B12711: Diff 17463.Oct 10 2022, 2:00 PM

ginsu requested review of this revision.Oct 10 2022, 2:00 PM

We use this in the web and native codebases

We definitely use this on web, but I don't think we use it on native... not that it makes a difference

ginsu edited the summary of this revision. (Show Details)Oct 10 2022, 2:09 PM

Let's use the same version range as we're using in web/package.json

Alternatively can update both to latest, but you'll need to go through release notes to ensure that there aren't any breaking changes (though this seems like a simple enough utility library that I'd be surprised if there were any)