[services][identity] create a struct for the users table in MySQL
ClosedPublic
Actions

Authored by varun on Oct 20 2022, 12:45 PM.

Details

Reviewers

atul
ashoat
• jon

Commits

rCOMMe7b0a922126f: [services][identity] create a struct for the users table in MySQL

Summary

this struct will store the data we need to move from the users table in MySQL to DynamoDB. we are omitting the password hash since we're not storing passwords on the Identity service, avatar since it's unused currently, and public_key since keys will be per-device.

Adding @ashoat on these DB-related diffs since he has a lot of context

Test Plan

cargo build (this is dead code so it can't break anything)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Oct 20 2022, 12:45 PM

Herald added a reviewer: • jon. · View Herald TranscriptOct 20 2022, 12:45 PM

Herald added subscribers: • abosh, tomek. · View Herald Transcript

Harbormaster completed remote builds in B12947: Diff 17750.Oct 20 2022, 12:56 PM

varun requested review of this revision.Oct 20 2022, 12:56 PM

Heads-up to other reviewers... things like public_key, social_proof, and device_id will be stored per-device on a separate devices table. @derek is doing the same thing on the keyserver side right now... in fact, he's removing some columns from users and making other columns optional, while adding columns to the cookies table (which corresponds to devices on the identity service / DDB side)

• jon added inline comments.Oct 21 2022, 12:05 PM

services/identity/src/populate_db.rs
1 ↗	(On Diff #17750)	I generally find myself always needing a debug version, so that I can do logging. But probably not an issue if we only use something like their username or id for logging.

The struct looks reasonable to me, but I don't have a ton of context here

This revision is now accepted and ready to land.Oct 24 2022, 9:05 AM

varun added inline comments.Oct 25 2022, 1:06 PM

services/identity/src/populate_db.rs
1 ↗	(On Diff #17750)	I usually add the derive traits when I actually need them. gonna leave this out for now

Closed by commit rCOMMe7b0a922126f: [services][identity] create a struct for the users table in MySQL (authored by varun). · Explain WhyOct 25 2022, 1:10 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMe7b0a922126f: [services][identity] create a struct for the users table in MySQL.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

populate_db.rs

5 lines

Diff 17911

View Options

services/identity/src/populate_db.rs

	Show All 21 Lines
	a {			a {
	text-decoration: none;			text-decoration: none;
	color: #2a5db0;			color: #2a5db0;
	}			}
	img,			img,
	iframe {			iframe {
	display: block;			display: block;
	}			}
	input[type='text'],			input[type='text'],
	input[type='password'],			input[type='password'],
	textarea {			textarea {
	atulUnsubmitted Not Done Inline Actions Moving the global input styling and moving it to the input component. Then why are we keeping styles like `border` and `border-radius`? Don't these styles also affect the `<textarea>` tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for `input` and another for `textarea`)? atul: > Moving the global input styling and moving it to the input component. Then why are we…
	benschacAuthorUnsubmitted Done Inline Actions Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect `textarea` elements. benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
	-webkit-appearance: none;
	-moz-appearance: none;
	-webkit-border-radius: 0;
	border: 1px solid #dddddd;			border: 1px solid #dddddd;
	border-radius: 1px;			border-radius: 1px;
	font-family: var(--font-stack);			font-family: var(--font-stack);
	}			}
	:global(#react-root) {			:global(#react-root) {
	display: flex;			display: flex;
	flex-direction: column;			flex-direction: column;
	height: 100%;			height: 100%;
	▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines

[services][identity] create a struct for the users table in MySQLClosedPublicActions