[services][identity] create a struct for the users table in MySQL
ClosedPublic
Actions

Authored by varun on Oct 20 2022, 12:45 PM.

Details

Reviewers

atul
ashoat
• jon

Commits

rCOMMe7b0a922126f: [services][identity] create a struct for the users table in MySQL

Summary

this struct will store the data we need to move from the users table in MySQL to DynamoDB. we are omitting the password hash since we're not storing passwords on the Identity service, avatar since it's unused currently, and public_key since keys will be per-device.

Adding @ashoat on these DB-related diffs since he has a lot of context

Test Plan

cargo build (this is dead code so it can't break anything)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Oct 20 2022, 12:45 PM

Herald added a reviewer: • jon. · View Herald TranscriptOct 20 2022, 12:45 PM

Herald added subscribers: • abosh, tomek. · View Herald Transcript

Harbormaster completed remote builds in B12947: Diff 17750.Oct 20 2022, 12:56 PM

varun requested review of this revision.Oct 20 2022, 12:56 PM

Heads-up to other reviewers... things like public_key, social_proof, and device_id will be stored per-device on a separate devices table. @derek is doing the same thing on the keyserver side right now... in fact, he's removing some columns from users and making other columns optional, while adding columns to the cookies table (which corresponds to devices on the identity service / DDB side)

• jon added inline comments.Oct 21 2022, 12:05 PM

services/identity/src/populate_db.rs
1 ↗	(On Diff #17750)	I generally find myself always needing a debug version, so that I can do logging. But probably not an issue if we only use something like their username or id for logging.