Page MenuHomePhabricator
Differential D5450

[GH Actions] Add `arm-linux-androideabi` target via `rustup` for Android CI
ClosedPublic
Actions

Authored by atul on Oct 20 2022, 2:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 9:08 PM
Unknown Object (File)
Fri, Nov 8, 9:08 PM
Unknown Object (File)
Fri, Nov 8, 9:08 PM
Unknown Object (File)
Fri, Nov 8, 9:04 PM
Unknown Object (File)
Tue, Nov 5, 2:08 AM
Unknown Object (File)
Tue, Oct 29, 12:00 AM
Unknown Object (File)
Sep 26 2024, 7:00 PM
Unknown Object (File)
Sep 8 2024, 12:05 PM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM339e83a168bb: [GH Actions] Add `arm-linux-androideabi` target via `rustup` for Android CI
Summary

Fix Android CI for GitHub Actions

Test Plan

See if CI passes

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D5450 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Oct 20 2022, 2:23 PM
Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 20 2022, 2:23 PM
Harbormaster completed remote builds in B12951: Diff 17792.Oct 20 2022, 2:36 PM
atul requested review of this revision.Oct 20 2022, 2:36 PM
ashoat accepted this revision.Oct 20 2022, 2:46 PM

rubberstamp

This revision is now accepted and ready to land.Oct 20 2022, 2:46 PM
varun requested changes to this revision.Oct 20 2022, 3:01 PM
varun added inline comments.
.github/workflows/android_ci.yml
28 ↗(On Diff #17792)

I think it should be: rustup target add aarch64-linux-android arm-linux-androideabi i686-linux-android x86_64-linux-android

This revision now requires changes to proceed.Oct 20 2022, 3:01 PM
varun accepted this revision.Oct 20 2022, 3:40 PM

please see the inline comment

This revision is now accepted and ready to land.Oct 20 2022, 3:40 PM
varun commandeered this revision.Oct 20 2022, 10:19 PM
varun edited reviewers, added: atul; removed: varun.
varun accepted this revision.Oct 20 2022, 10:22 PM
varun foisted this revision upon atul.
varun edited reviewers, added: varun; removed: atul.
atul updated this revision to Diff 17813.Oct 21 2022, 10:56 AM

update before landing

This revision was landed with ongoing or failed builds.Oct 21 2022, 10:58 AM
Closed by commit rCOMM339e83a168bb: [GH Actions] Add `arm-linux-androideabi` target via `rustup` for Android CI (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM339e83a168bb: [GH Actions] Add `arm-linux-androideabi` target via `rustup` for Android CI.
Harbormaster failed remote builds in B12968: Diff 17813!Oct 21 2022, 11:07 AM
Harbormaster completed remote builds in B12968: Diff 17813.Oct 21 2022, 11:31 AM

Revision Contents
Changeset List

PathSize
.github/
workflows/
3 lines

Diff 17813

View Options

.github/workflows/android_ci.yml

Loading...