[native][android] move `rustup target add` from CMakeLists.txt to build.gradle
ClosedPublic
Actions

Authored by varun on Oct 21 2022, 3:28 PM.

Details

Reviewers

atul
• jon

Commits

rCOMMf513e3e8c5ca: [native][android] move `rustup target add` from CMakeLists.txt to build.gradle

Summary

It looks like cargo is trying to use the new cross-compilation targets before they're available in the rust toolchain. If we make them available in a preceding task in build.gradle, we avoid this race condition.

Test Plan

cd native/android && ./gradlew bundleRelease

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Oct 21 2022, 3:28 PM

Herald added subscribers: • abosh, tomek, ashoat. · View Herald TranscriptOct 21 2022, 3:28 PM

Harbormaster completed remote builds in B12964: Diff 17807.Oct 21 2022, 3:41 PM

varun requested review of this revision.Oct 21 2022, 3:41 PM

Going to assume that the android gate passing means this is likely to succeed.

Ran the build again, just to make sure: https://buildkite.com/comm/tunnelbroker-build-docker/builds/3095

Not very familiar with Gradle/Groovy, but looks correct.

This revision is now accepted and ready to land.Oct 21 2022, 7:20 PM

Closed by commit rCOMMf513e3e8c5ca: [native][android] move `rustup target add` from CMakeLists.txt to build.gradle. · Explain WhyOct 21 2022, 7:22 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMf513e3e8c5ca: [native][android] move `rustup target add` from CMakeLists.txt to build.gradle.

Revision Contents
Changeset List

Path

Size

native/

android/

app/

CMakeLists.txt

11 lines

build.gradle

12 lines

Diff 17826

View Options

native/android/app/CMakeLists.txt