[web] Don't display current user in UserList
ClosedPublic
Actions

Authored by michal on Oct 24 2022, 8:32 AM.

Details

Reviewers

tomek
atul
• abosh
ginsu

Commits

rCOMM24647a5f1e20: [web] Don't display current user in UserList

Summary

ENG-2015
Current user shouldn't be displayed in UserLists (blocking/ sending friend request to yourself doesn't make sense),

Test Plan

Check if the current user is not visible in the block/ friend list and can't be searched for. Check if other users can still be selected.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Oct 24 2022, 8:32 AM

Herald added a subscriber: ashoat. · View Herald TranscriptOct 24 2022, 8:32 AM

Harbormaster completed remote builds in B13001: Diff 17860.Oct 24 2022, 8:46 AM

michal requested review of this revision.Oct 24 2022, 8:46 AM

Nice!! Thanks for creating both the issue and the fix :)

Just checking – do we do the same thing on native currently?

Looks good, but make sure to answer question about native before landing

This revision is now accepted and ready to land.Oct 24 2022, 11:27 AM

We handle this issue correctly on native (here).

Closed by commit rCOMM24647a5f1e20: [web] Don't display current user in UserList (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyOct 25 2022, 2:12 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM24647a5f1e20: [web] Don't display current user in UserList.

Revision Contents
Changeset List

Path

Size

web/

settings/

relationship/

add-users-list.react.js

9 lines

Diff 17887

View Options

web/settings/relationship/add-users-list.react.js

[web] Don't display current user in UserListClosedPublicActions