Page MenuHomePhabricator
Differential D5476

[native] Refactor Spoiler component to MarkdownSpoiler
AbandonedPublicDraft
Actions

Authored by rohan on Oct 25 2022, 5:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 3:57 AM
Unknown Object (File)
Mon, Mar 17, 3:52 AM
Unknown Object (File)
Tue, Feb 25, 2:58 PM
Unknown Object (File)
Feb 17 2025, 2:04 AM
Unknown Object (File)
Feb 14 2025, 6:24 PM
Unknown Object (File)
Feb 12 2025, 9:17 PM
Unknown Object (File)
Feb 12 2025, 9:17 PM
Unknown Object (File)
Jan 31 2025, 5:53 PM
View All Files
Subscribers
• abosh
ashoat
tomek

Details

Reviewers
atul
ginsu
Summary

For consistency with the existing MarkdownLink component in
native, refactoring Spoiler to MarkdownSpoiler and putting it in the same
directory native/markdown/... makes the most sense. This is Step 2 in
ENG-2072
(https://linear.app/comm/issue/ENG-2072/maintain-the-spoiler-state-upon-opening-textmessagetooltipmodal).

Test Plan

Spoiler text still works as expected, and they are revealed on
click.

Diff Detail

Repository
rCOMM Comm
Branch
spoiler
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
components/
markdown/
components/
6 lines
markdown/
6 lines

Diff 17892

View Options

native/components/spoiler.react.js

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Linesstd::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request); Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody(); Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();
std::string result; std::stringstream buffer;
result.resize(size); buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1); std::string result(buffer.str());
std::string cpy = result;
return result; return result;
} }
void AwsS3Bucket::getObjectDataChunks( void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName, const std::string &objectName,
const std::function<void(const std::string &)> &callback, const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const { const size_t chunkSize) const {
Show All 16 Lines for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome = Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request); getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage()); throw std::runtime_error(getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
std::stringstream buffer;
buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
result.resize(nextSize); result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result); callback(result);
} }
} }
void AwsS3Bucket::appendToObject( void AwsS3Bucket::appendToObject(
const std::string &objectName, const std::string &objectName,
const std::string &data) { const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName); const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines
View Options

native/markdown/markdown-spoiler.react.js

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Linesstd::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request); Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody(); Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();
std::string result; std::stringstream buffer;
result.resize(size); buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1); std::string result(buffer.str());
std::string cpy = result;
return result; return result;
} }
void AwsS3Bucket::getObjectDataChunks( void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName, const std::string &objectName,
const std::function<void(const std::string &)> &callback, const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const { const size_t chunkSize) const {
Show All 16 Lines for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome = Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request); getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage()); throw std::runtime_error(getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
std::stringstream buffer;
buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
result.resize(nextSize); result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result); callback(result);
} }
} }
void AwsS3Bucket::appendToObject( void AwsS3Bucket::appendToObject(
const std::string &objectName, const std::string &objectName,
const std::string &data) { const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName); const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines
View Options

native/markdown/rules.react.js

Show First 20 Lines • Show All 111 Lines • ▼ Show 20 Linesstd::string AwsS3Bucket::getObjectData(const std::string &objectName) const {
Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request); Aws::S3::Model::GetObjectOutcome outcome = getS3Client()->GetObject(request);
if (!outcome.IsSuccess()) { if (!outcome.IsSuccess()) {
throw std::runtime_error(outcome.GetError().GetMessage()); throw std::runtime_error(outcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody(); Aws::IOStream &retrievedFile = outcome.GetResultWithOwnership().GetBody();
std::string result; std::stringstream buffer;
result.resize(size); buffer << retrievedFile.rdbuf();
retrievedFile.get((char *)result.data(), size + 1); std::string result(buffer.str());
std::string cpy = result;
return result; return result;
} }
void AwsS3Bucket::getObjectDataChunks( void AwsS3Bucket::getObjectDataChunks(
const std::string &objectName, const std::string &objectName,
const std::function<void(const std::string &)> &callback, const std::function<void(const std::string &)> &callback,
const size_t chunkSize) const { const size_t chunkSize) const {
Show All 16 Lines for (size_t offset = 0; offset < fileSize; offset += chunkSize) {
Aws::S3::Model::GetObjectOutcome getOutcome = Aws::S3::Model::GetObjectOutcome getOutcome =
getS3Client()->GetObject(request); getS3Client()->GetObject(request);
if (!getOutcome.IsSuccess()) { if (!getOutcome.IsSuccess()) {
throw std::runtime_error(getOutcome.GetError().GetMessage()); throw std::runtime_error(getOutcome.GetError().GetMessage());
} }
Aws::IOStream &retrievedFile = Aws::IOStream &retrievedFile =
getOutcome.GetResultWithOwnership().GetBody(); getOutcome.GetResultWithOwnership().GetBody();
std::string result;
std::stringstream buffer;
buffer << retrievedFile.rdbuf();
std::string result(buffer.str());
result.resize(nextSize); result.resize(nextSize);
retrievedFile.get((char *)result.data(), nextSize + 1);
callback(result); callback(result);
} }
} }
void AwsS3Bucket::appendToObject( void AwsS3Bucket::appendToObject(
const std::string &objectName, const std::string &objectName,
const std::string &data) { const std::string &data) {
const size_t objectSize = this->getObjectSize(objectName); const size_t objectSize = this->getObjectSize(objectName);
▲ Show 20 Lines • Show All 55 Lines • Show Last 20 Lines