Page MenuHomePhabricator
Differential D5548

[services][identity] introduce RPC to return the public key associated with a given user ID and device ID
ClosedPublic
Actions

Authored by varun on Nov 7 2022, 12:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 6:09 PM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
Unknown Object (File)
Sat, Nov 2, 8:14 PM
Unknown Object (File)
Sat, Nov 2, 8:12 PM
View All Files
Subscribers
• abosh

Details

Reviewers
ashoat
atul
tomek
• jon
Commits
rCOMMe75f9264bacf: [services][identity] introduce RPC to return the public key associated with a…
Summary

keyservers need to be able to look up the public key associated with a given user and device ID in order to verify signed messages from users. this diff introduces a new RPC for this lookup.

Test Plan

successfully built the Identity service and native rust library, which consume this .proto file

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Nov 7 2022, 12:09 PM
Herald added a reviewer: • jon. · View Herald TranscriptNov 7 2022, 12:09 PM
Herald added a subscriber: • abosh. · View Herald Transcript
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2022, 12:14 PM
Harbormaster failed remote builds in B13234: Diff 18161!
varun updated this revision to Diff 18162.Nov 7 2022, 12:16 PM

updated generated files

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2022, 12:21 PM
Harbormaster failed remote builds in B13235: Diff 18162!
varun added a comment.Nov 7 2022, 12:22 PM

includes some changes to generated tunnelbroker files (from running yarn codegen-grpc). don't think these are used anymore, but no harm in keeping them up to date

varun requested review of this revision.Nov 7 2022, 12:43 PM

android ci failure looks unrelated

ashoat accepted this revision.Nov 7 2022, 1:05 PM

.proto changes make sense to me, haven't reviewed the Rust stuff

varun updated this revision to Diff 18164.Nov 7 2022, 1:37 PM

rebase

Harbormaster failed remote builds in B13237: Diff 18164!Nov 7 2022, 1:48 PM
tomek accepted this revision.Nov 8 2022, 4:00 AM
This revision is now accepted and ready to land.Nov 8 2022, 4:00 AM
varun updated this revision to Diff 18201.Nov 8 2022, 7:48 AM

rebase

Harbormaster completed remote builds in B13266: Diff 18201.Nov 8 2022, 8:02 AM
Closed by commit rCOMMe75f9264bacf: [services][identity] introduce RPC to return the public key associated with a… (authored by varun). · Explain WhyNov 8 2022, 8:04 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMe75f9264bacf: [services][identity] introduce RPC to return the public key associated with a….

Revision Contents
Changeset List

Diff 18209

View Options

services/identity/src/service.rs

Loading...
View Options

shared/protos/_generated/identity.grpc.pb.h

Loading...
View Options

shared/protos/_generated/identity.grpc.pb.cc

Loading...
View Options

shared/protos/_generated/identity.pb.h

Loading...
View Options

shared/protos/_generated/identity.pb.cc

Loading...
View Options

shared/protos/_generated/tunnelbroker.grpc.pb.h

Loading...
View Options

shared/protos/_generated/tunnelbroker.pb.h

Loading...
View Options

shared/protos/_generated/tunnelbroker.pb.cc

Loading...
View Options

shared/protos/identity.proto

Loading...