Put node_modules bin directory on PATH as part of nix develop
Details
Details
- Reviewers
atul varun ashoat - Commits
- rCOMM661815bbe3c5: [Nix] Add node_modules/.bin to path
nix develop which react-native # points to node_modules which flow # points to node_modules cd lib flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
One concern here. This $PATH hack is a little different from the mainline instructions, where we use ./node_modules/.bin rather than $PRJ_ROOT/node_modules/.bin.
The workflow we have for running Flow is to cd into a directory and then run flow, eg. cd landing && flow. This will run Flow specifically for the landing workspace.
I'm not sure if cd landing && flow works specific to landing because the binary is being run from landing/node_modules/.bin vs. node_modules/.bin, or because the binary detects the current working directory that called it.
To confirm things still work correctly, @jon can you amend your test plan to actually test Flow rather than running which flow?
Comment Actions
In the future, would be great if these test plans are more robust. Instead of testing the most immediate thing, you should be testing the full workflow.