Paths

Table of Contentst

Differential D5692

[native] Allow getDevServerHostname to be called from release mode
ClosedPublic
Actions

Authored by ashoat on Nov 20 2022, 11:29 AM.

Tags

None

Referenced Files

	F3492298: D5692.diff
	Wed, Dec 18, 10:59 PM

	Unknown Object (File)
	Tue, Nov 19, 3:11 AM

	Unknown Object (File)
	Nov 18 2024, 7:59 PM

	Unknown Object (File)
	Nov 18 2024, 6:27 PM

	Unknown Object (File)
	Nov 18 2024, 3:56 PM

	Unknown Object (File)
	Nov 15 2024, 8:24 PM

	Unknown Object (File)
	Nov 15 2024, 11:59 AM

	Unknown Object (File)
	Oct 26 2024, 8:55 PM

View All 53 Files

Subscribers

None

Details

Reviewers

tomek
atul

Commits

rCOMM9d1ff85e55d0: [native] Allow getDevServerHostname to be called from release mode

Summary

We don't actually have any code that does this, but I was debugging a release build and wanted to use Reactrotron. Uncommenting the release condition around native/reactrotron.js led to this invariant firing, which I thought was kinda unnecessary.

Test Plan

Confirm the invariant no longer fires after uncommenting the release condition around native/reactotron.js

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 20 2022, 11:29 AM

Harbormaster completed remote builds in B13597: Diff 18625.Nov 20 2022, 11:43 AM

ashoat requested review of this revision.Nov 20 2022, 11:43 AM

atul accepted this revision.Nov 21 2022, 1:31 PM

This revision is now accepted and ready to land.Nov 21 2022, 1:31 PM

Closed by commit rCOMM9d1ff85e55d0: [native] Allow getDevServerHostname to be called from release mode (authored by ashoat). · Explain WhyNov 21 2022, 2:30 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM9d1ff85e55d0: [native] Allow getDevServerHostname to be called from release mode.

Revision Contents
Changeset List

Path

Size

native/

utils/

1 line

Diff 18708

native/utils/url-utils.js

Loading...