Page MenuHomePhabricator

[native] "Flip the switch" to enable video messages
ClosedPublic

Authored by atul on Nov 29 2022, 2:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 9:35 PM
Unknown Object (File)
Thu, Dec 19, 9:35 PM
Unknown Object (File)
Thu, Dec 19, 9:34 PM
Unknown Object (File)
Thu, Dec 19, 9:21 PM
Unknown Object (File)
Wed, Dec 4, 8:33 AM
Unknown Object (File)
Nov 19 2024, 3:36 PM
Unknown Object (File)
Nov 19 2024, 3:36 PM
Unknown Object (File)
Nov 19 2024, 3:35 PM
Subscribers

Details

Summary

Now that we have video messages working end-to-end, we can "flip the switch" to enable video messages.

Specifically:

  1. Set serverCanHandle to true for video types in lib/media/file-utils
  2. Set versionCode for hasMinCodeVersion check in multimedia-message-spec to 158.
  3. Add MediaLibrary.MediaType.video to mediaType array in multimedia-gallery-keyboard so users can select videos from their media gallery.
  4. Set persistConfig.version to 32 so multimedia unshimming migration runs.
  5. Add messageTypes.MULTIMEDIA to unshim-utils:localUnshimTypes
Test Plan

All the diffs that came before this one tested various parts of the video message ssytem independently.

In addition I've done a decent amount of testing in my local dev environment to make sure things work as expected... going to do additional testing before I land this diff... and further testing before making a release that includes these changes.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Nov 29 2022, 2:26 PM
This revision is now accepted and ready to land.Nov 29 2022, 2:27 PM
This revision was landed with ongoing or failed builds.Nov 29 2022, 2:36 PM
This revision was automatically updated to reflect the committed changes.