This diff disables the 'Change password' button within user settings until the user has entered text into each of the input fields on the modal. Linked the the linear task ENG-2014
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Not sure if inputDisabled handles this already, but I feel like we should be doing other checks too for example
- new password and confirm new password are the same
- current password matches the correct current password
But overall looks good, and I know this wasn't part of the linear task, but might be a good follow-up diff to what we have right now.
Comment Actions
current password matches the correct current password
I don't think we should be doing this validation on the front-end.
new password and confirm new password are the same
We could do this validation before enabling the "Change password" button... but in my experience that check usually happens after the "submit" or "change password" button is pressed.