[native] Prevent text from being highlighted on press when if is no pressable
ClosedPublic
Actions

Authored by rohan on Dec 1 2022, 2:06 PM.

Details

Reviewers

atul
ginsu
ashoat

Commits

rCOMM272876219926: [native] Prevent text from being highlighted on press when if is no pressable

Summary

We want to only define an onPress handler in MarkdownParagraph if there is a pressable in the message.

Context: https://linear.app/comm/issue/ENG-2389/prevent-text-from-being-highlighted-on-press-when-if-is-no-pressable

Test Plan

The before is attached in the Linear post, and I will attach the after video below.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 1 2022, 2:06 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 1 2022, 2:06 PM

rohan edited the test plan for this revision. (Show Details)Dec 1 2022, 2:06 PM

rohan attached a referenced file: F268801: ENG-2389.mov. (Show Details)

rohan edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B13922: Diff 19078.Dec 1 2022, 2:19 PM

rohan requested review of this revision.Dec 1 2022, 2:19 PM

ashoat accepted this revision.Dec 1 2022, 2:21 PM

ashoat removed 1 blocking reviewer(s): atul.

This revision is now accepted and ready to land.Dec 1 2022, 2:21 PM

Closed by commit rCOMM272876219926: [native] Prevent text from being highlighted on press when if is no pressable (authored by rohan). · Explain WhyDec 1 2022, 2:37 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM272876219926: [native] Prevent text from being highlighted on press when if is no pressable.

Revision Contents
Changeset List

Path

Size

native/

markdown/

markdown-paragraph.react.js

13 lines

Diff 19082

View Options

native/markdown/markdown-paragraph.react.js

[native] Prevent text from being highlighted on press when if is no pressableClosedPublicActions