Page MenuHomePhabricator

[services] Tunnelbroker - Removing rudimental `messageID` from messages from client to Tunnelbroker
ClosedPublic

Authored by max on Dec 5 2022, 3:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 28, 8:37 PM
Unknown Object (File)
Fri, Jun 21, 8:40 PM
Unknown Object (File)
Fri, Jun 21, 8:40 PM
Unknown Object (File)
Fri, Jun 21, 8:40 PM
Unknown Object (File)
Fri, Jun 21, 8:40 PM
Unknown Object (File)
Mon, Jun 17, 10:56 PM
Unknown Object (File)
Mon, Jun 17, 10:49 PM
Unknown Object (File)
Mon, Jun 17, 10:49 PM
Subscribers

Details

Summary

This diff removes the rudimental messageID field in the Tunnelbroker protocol buffers file for the Client to Tunnelbroker messages communication.

When the client sends messages to the Tunnelbroker the Tunnelbroker sends back message IDs to the client to confirm they are processed. Message IDs are generated on the Tunnelbroker side and are unique IDs for each message. We should remove the messageID from the protobuf file for the messages that come from the client to the Tunnelbroker as it's not used. That field came from the reason that the structure of the messages should be the same for the Tunnelbroker -> Client and Client -> Tunnelbroker communication, but it's changed due to the API changes, and this rudimental field is left and should be removed. The API description in an architecture review.

Linear task: ENG-2405

Test Plan
  1. Tunnelbroker service is successfully built.
  2. Tests for the Tunnelbroker are passed.
  3. Manual testing of the API is passed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max held this revision as a draft.
max edited the test plan for this revision. (Show Details)
max edited reviewers, added: tomek, varun; removed: jon.
max published this revision for review.Dec 5 2022, 6:07 AM
max edited the summary of this revision. (Show Details)
max retitled this revision from [services] Tunnelbroker - Remove `messageID` from messages from client to Tunnelbroker to [services] Tunnelbroker - Removing rudimental `messageID` from messages from client to Tunnelbroker.
tomek added a reviewer: ashoat.

Adding @ashoat because the proto file is changed.

This revision is now accepted and ready to land.Dec 6 2022, 7:02 AM

Rebasing and merging on master changes.