[web] Add unread indicator within subchannel model
ClosedPublic
Actions

Authored by • adar on Dec 5 2022, 2:24 PM.

Details

Reviewers

atul
ginsu
rohan

Commits

rCOMM453b74bf6d6b: [web] Add unread indicator within subchannel model

Summary

This diff adds styling so that unread subchannel messages are consistent with the rest of the web app, that is, they are made 'semi-bold' and that the color of the subchannel name, sender, text preview, and time are made white.

Deciding to change the color of all the subchannel elements was something I thought was appropriate but I'm happy to tinker some more with only color-changing certain elements.

This is one half of the linear task ENG-2089. The next step is to do this process for unread indicators for the sidebar modals.

Test Plan

Unread SubChannel	Read Subchannel

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• adar created this revision.Dec 5 2022, 2:24 PM

• adar held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 5 2022, 2:24 PM

• adar edited the test plan for this revision. (Show Details)Dec 5 2022, 2:25 PM

• adar edited the summary of this revision. (Show Details)Dec 5 2022, 2:28 PM

• adar edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B13977: Diff 19150.Dec 5 2022, 2:37 PM

• adar published this revision for review.Dec 5 2022, 2:43 PM

Looks good!

This revision is now accepted and ready to land.Dec 6 2022, 10:43 AM

Closed by commit rCOMM453b74bf6d6b: [web] Add unread indicator within subchannel model (authored by • adar). · Explain WhyDec 7 2022, 6:57 AM

This revision was automatically updated to reflect the committed changes.

• adar added a commit: rCOMM453b74bf6d6b: [web] Add unread indicator within subchannel model.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

subchannels/

subchannel.react.js

10 lines

subchannels-modal.css

5 lines

Diff 19214

View Options

web/modals/threads/subchannels/subchannel.react.js

				use clap::{Parser, Subcommand};
	use tonic::transport::Server;			use tonic::transport::Server;

				mod keygen;
				mod opaque;
	mod service;			mod service;

				use keygen::generate_and_persist_keypair;
	use service::{IdentityServiceServer, MyIdentityService};			use service::{IdentityServiceServer, MyIdentityService};

	const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";			const IDENTITY_SERVICE_SOCKET_ADDR: &str = "[::]:50051";
				const DEFAULT_SECRETS_DIRECTORY: &str = "secrets";

				#[derive(Parser)]
				#[clap(author, version, about, long_about = None)]
				#[clap(propagate_version = true)]
				struct Cli {
				#[clap(subcommand)]
				command: Commands,
				}

				#[derive(Subcommand)]
				enum Commands {
				/// Runs the server
				Server,
				/// Generates and persists a keypair to use for PAKE registration and login
				Keygen {
				#[clap(short, long)]
				#[clap(default_value_t = String::from(DEFAULT_SECRETS_DIRECTORY))]
				dir: String,
				},
				}

	#[tokio::main]			#[tokio::main]
	async fn main() -> Result<(), Box<dyn std::error::Error>> {			async fn main() -> Result<(), Box<dyn std::error::Error>> {
				let cli = Cli::parse();
				match &cli.command {
				Commands::Keygen { dir } => {
				generate_and_persist_keypair(dir)?;
				}
				Commands::Server => {
	let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;			let addr = IDENTITY_SERVICE_SOCKET_ADDR.parse()?;
	let identity_service = MyIdentityService::default();			let identity_service = MyIdentityService::default();

	Server::builder()			Server::builder()
	.add_service(IdentityServiceServer::new(identity_service))			.add_service(IdentityServiceServer::new(identity_service))
	.serve(addr)			.serve(addr)
	.await?;			.await?;
				}
				}

	Ok(())			Ok(())
	}			}