Details

Reviewers

tomek
atul
ashoat

Commits

rCOMM75f181ad4456: [desktop] Code signing for disk image

Summary

This diff configures electron-forge to sign and notarize .dmg files.

Additionally I'm using the fileicon utility for changing the .dmg icon. I think having default macOS dmg icon is the standard so there's no explicit option for it in the electron-forge.

Test Plan

Test if running development version works. Check if making the .dmg works (yarn make --platform darwin).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Dec 6 2022, 6:20 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 6 2022, 6:21 AM

Harbormaster failed remote builds in B14005: Diff 19178!

michal added a parent revision: D5735: [desktop] Add babel support.Dec 6 2022, 6:37 AM

After talking to ashoat, we don't need to change the .dmg file icon so I've removed fileicon dependency which should fix the build failures.

Harbormaster completed remote builds in B14015: Diff 19190.Dec 6 2022, 7:43 AM

michal requested review of this revision.Dec 6 2022, 7:43 AM

Looks good to me.

Might be worth talking to the design team about the DMG background with the arrow and whatnot. It seems like it would be a relatively quick/well scoped task? (CC @ashoat)

desktop/forge.config.cjs
70 ↗	(On Diff #19190)	Looks we're using `app.comm` instead of `app.comm.macos` here, was that intentional? (I just don't remember the context)

This revision is now accepted and ready to land.Dec 6 2022, 10:55 AM

Honestly don't think we need to think that hard about the design for the DMG background.

Back to you with question about bundle identifier

desktop/forge.config.cjs
70 ↗	(On Diff #19190)	That's confusing since I think we use the same bundle identifier for the iOS app, right? Won't that cause problems?

This revision now requires changes to proceed.Dec 6 2022, 7:42 PM

The bundleID wasn't completely intentional, thanks for noticing. I don't think it would cause problems (apple offers universal purchase which requires the same ID on both iOS and macOS, and we could create a macOS section in the current comm App Store Record), but I don't think there are any advantages for us so I'm changes it to app.comm.macos.

(Additionally I've missed a mention of the removed fileicon package in the ignore option so I've removed that.)

Harbormaster completed remote builds in B14024: Diff 19199.Dec 7 2022, 2:32 AM

Remove the @electron-forge/maker-zip dependency.

Harbormaster completed remote builds in B14037: Diff 19212.Dec 7 2022, 7:02 AM

tomek accepted this revision.Dec 8 2022, 5:03 AM

ashoat accepted this revision.Dec 8 2022, 10:40 AM

This revision is now accepted and ready to land.Dec 8 2022, 10:40 AM

Closed by commit rCOMM75f181ad4456: [desktop] Code signing for disk image (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyDec 12 2022, 2:39 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM75f181ad4456: [desktop] Code signing for disk image.