Paths

Table of Contentst

[web] Introduce spoiler colors in the first section of theme.css
ClosedPublic
Actions

Authored by rohan on Dec 16 2022, 7:06 AM.

Tags

None

Referenced Files

	F3498561: D5881.id19435.diff
	Thu, Dec 19, 9:35 PM

	F3498559: D5881.id19433.diff
	Thu, Dec 19, 9:35 PM

	F3498555: D5881.id.diff
	Thu, Dec 19, 9:34 PM

	Unknown Object (File)
	Thu, Dec 19, 9:21 PM

	Unknown Object (File)
	Sat, Dec 7, 1:37 PM

	Unknown Object (File)
	Sat, Dec 7, 1:36 PM

	Unknown Object (File)
	Sat, Dec 7, 1:36 PM

	Unknown Object (File)
	Sat, Dec 7, 1:19 PM

View All Files

Subscribers

ashoat

tomek

Details

Reviewers

tomek
ginsu
atul

Commits

rCOMM520d1f1b5422: [web] Introduce spoiler colors in the first section of theme.css

Summary

As mentioned by @tomek in D5836, we should follow convention and introduce a variable in the first section of theme.css and use it instead of hard coding both values.

Test Plan

Ensure that spoilers still appear as before on web.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 16 2022, 7:06 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 16 2022, 7:06 AM

Harbormaster completed remote builds in B14201: Diff 19433.Dec 16 2022, 7:18 AM

rohan requested review of this revision.Dec 16 2022, 7:18 AM

If @tomek doesn't get back to you today, let me know and I can accept this (it's @rohan's last day of his internship)

tomek accepted this revision.Dec 16 2022, 7:55 AM

This revision is now accepted and ready to land.Dec 16 2022, 7:55 AM

Closed by commit rCOMM520d1f1b5422: [web] Introduce spoiler colors in the first section of theme.css (authored by rohan). · Explain WhyDec 16 2022, 8:01 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM520d1f1b5422: [web] Introduce spoiler colors in the first section of theme.css.

Revision Contents
Changeset List

Path

Size

web/

theme.css

6 lines

Diff 19435

View Options

[web] Introduce spoiler colors in the first section of theme.cssClosedPublicActions