Remove unused SQLite dependencies from NotificationService
ClosedPublic
Actions

Authored by marcin on Dec 19 2022, 6:50 AM.

Details

Reviewers

tomek
atul

Commits

rCOMM93e8ecf04eb2: Remove unused SQLite dependencies from NotificationService

Summary

This differential removes SQLite -related dependencies from NotificationService. Currently we do not update SQLite from NotificationService so keeping its dependencies in NotificationService's dependencies compile sources is a bad practice. Related context is here: https://linear.app/comm/issue/ENG-1979/using-rust-with-sqlite

Test Plan

Build the app.

Diff Detail

Repository

rCOMM Comm

Branch

marcin/eng-1996

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Dec 19 2022, 6:50 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 19 2022, 6:50 AM

Harbormaster completed remote builds in B14313: Diff 19555.Dec 19 2022, 7:01 AM

marcin requested review of this revision.Dec 19 2022, 7:01 AM

tomek requested changes to this revision.Dec 20 2022, 9:52 AM

tomek added inline comments.

native/ios/Comm.xcodeproj/project.pbxproj
983 ↗	(On Diff #19555)	This doesn't seem to be SQLite-related

This revision now requires changes to proceed.Dec 20 2022, 9:52 AM

Bring CommSecureStore back to NotificationService dependencies

Harbormaster completed remote builds in B14624: Diff 19945.Dec 21 2022, 6:21 AM

tomek accepted this revision.Dec 21 2022, 6:21 AM

tomek added inline comments.

native/ios/Comm.xcodeproj/project.pbxproj
60 ↗	(On Diff #19945)	Xcode might disagree, but I would expect this file not being touched, instead of being remove and added. But it doesn't matter that much.