[keyserver] include targetMessageID in fetchCollapsableNotifs query
ClosedPublic
Actions

Authored by ginsu on Dec 20 2022, 1:02 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM26ca563342ed: [keyserver] include targetMessageID in fetchCollapsableNotifs query

Summary

included targetMessageID in fetchCollapsableNotifs query. Was doing some final tests of message liking and noticed an invariant going off since targetMessageID was not included in this query

Test Plan

After these changes the following invariant message no longer appears in the logs

Screenshot 2022-12-20 at 3.56.14 PM.png (2×3 px, 3 MB)

Diff Detail

Repository

rCOMM Comm

Branch

eng-2243 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Dec 20 2022, 1:02 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 20 2022, 1:02 PM

ginsu edited the test plan for this revision. (Show Details)Dec 20 2022, 1:04 PM

ginsu added reviewers: atul, tomek.

ginsu attached a referenced file: F296825: Screenshot 2022-12-20 at 3.56.14 PM.png. (Show Details)

Harbormaster completed remote builds in B14582: Diff 19883.Dec 20 2022, 1:11 PM

ginsu requested review of this revision.Dec 20 2022, 1:11 PM

tomek accepted this revision.Dec 21 2022, 7:02 AM

atul accepted this revision.Dec 21 2022, 10:58 AM

This revision is now accepted and ready to land.Dec 21 2022, 10:58 AM

Closed by commit rCOMM26ca563342ed: [keyserver] include targetMessageID in fetchCollapsableNotifs query (authored by ginsu). · Explain WhyDec 21 2022, 11:02 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM26ca563342ed: [keyserver] include targetMessageID in fetchCollapsableNotifs query.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

message-fetchers.js

3 lines

Diff 19883

View Options

keyserver/src/fetchers/message-fetchers.js

[keyserver] include targetMessageID in fetchCollapsableNotifs queryClosedPublicActions