Page MenuHomePhabricator

[landing] Style SIWE page a bit better and improve UX
ClosedPublic

Authored by ashoat on Dec 22 2022, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 4:23 PM
Unknown Object (File)
Sat, Nov 9, 4:03 PM
Unknown Object (File)
Sat, Nov 9, 3:35 PM
Unknown Object (File)
Sat, Nov 9, 7:00 AM
Unknown Object (File)
Sat, Nov 9, 7:00 AM
Unknown Object (File)
Sat, Nov 9, 6:32 AM
Unknown Object (File)
Thu, Nov 7, 5:54 AM
Unknown Object (File)
Wed, Nov 6, 6:30 AM
Subscribers

Details

Summary
  1. Get rid of the button and just open the connect modal right away
  2. Get the styling to match what our WebView looks like
Test Plan

Note that this is combination with several other changes on the native side that will be coming in future diffs (introduction of bottom-sheet, some styling) :

Screenshot 2022-12-22 at 12.54.12 PM.png (2×1 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

RainbowKit is honestly poorly written and not customizable enough – we should get rid of it sometime soon, but for now we're stuck with it

landing/siwe.css
3 ↗(On Diff #20036)

I could modify landing/landing.react.js to only apply background conditionally – let me know if you prefer that

27–32 ↗(On Diff #20036)

There doesn't seem to be a better way to do this

Don't open the modal unless we have the nonce

This revision is now accepted and ready to land.Dec 22 2022, 12:54 PM
landing/siwe.css
3 ↗(On Diff #20036)

Actually there's no reason that this should the same as landing... will separate them

landing/siwe.css
3 ↗(On Diff #20036)
This revision was landed with ongoing or failed builds.Dec 22 2022, 3:36 PM
This revision was automatically updated to reflect the committed changes.