- Get rid of the button and just open the connect modal right away
- Get the styling to match what our WebView looks like
Details
- Reviewers
atul - Commits
- rCOMMe2ec8f39eec8: [landing] Style SIWE page a bit better and improve UX
Note that this is combination with several other changes on the native side that will be coming in future diffs (introduction of bottom-sheet, some styling) :
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
RainbowKit is honestly poorly written and not customizable enough – we should get rid of it sometime soon, but for now we're stuck with it
landing/siwe.css | ||
---|---|---|
3 ↗ | (On Diff #20036) | I could modify landing/landing.react.js to only apply background conditionally – let me know if you prefer that |
27–32 ↗ | (On Diff #20036) | There doesn't seem to be a better way to do this |
landing/siwe.css | ||
---|---|---|
3 ↗ | (On Diff #20036) | Actually there's no reason that this should the same as landing... will separate them |
landing/siwe.css | ||
---|---|---|
3 ↗ | (On Diff #20036) | Harder than expected... creating backlog task: https://linear.app/comm/issue/ENG-2531/siwe-shouldnt-render-within-landing |
landing/siwe.css | ||
---|---|---|
1–3 | This borked landing page: https://linear.app/comm/issue/ENG-2535/landing-page-background-is-messed-up |