Page MenuHomePhabricator
Differential D6003

[landing] Style SIWE page a bit better and improve UX
ClosedPublic
Actions

Authored by ashoat on Dec 22 2022, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 4:23 PM
Unknown Object (File)
Sat, Nov 9, 4:03 PM
Unknown Object (File)
Sat, Nov 9, 3:35 PM
Unknown Object (File)
Sat, Nov 9, 7:00 AM
Unknown Object (File)
Sat, Nov 9, 7:00 AM
Unknown Object (File)
Sat, Nov 9, 6:32 AM
Unknown Object (File)
Thu, Nov 7, 5:54 AM
Unknown Object (File)
Wed, Nov 6, 6:30 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMMe2ec8f39eec8: [landing] Style SIWE page a bit better and improve UX
Summary
  1. Get rid of the button and just open the connect modal right away
  2. Get the styling to match what our WebView looks like
Test Plan

Note that this is combination with several other changes on the native side that will be coming in future diffs (introduction of bottom-sheet, some styling) :

Screenshot 2022-12-22 at 12.54.12 PM.png (2×1 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/siwe
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 22 2022, 11:55 AM
Herald added a subscriber: tomek. · View Herald TranscriptDec 22 2022, 11:55 AM
ashoat added a comment.Dec 22 2022, 11:56 AM

RainbowKit is honestly poorly written and not customizable enough – we should get rid of it sometime soon, but for now we're stuck with it

landing/siwe.css
3 ↗(On Diff #20036)

I could modify landing/landing.react.js to only apply background conditionally – let me know if you prefer that

27–32 ↗(On Diff #20036)

There doesn't seem to be a better way to do this

ashoat edited the test plan for this revision. (Show Details)Dec 22 2022, 11:57 AM
ashoat updated this revision to Diff 20037.Dec 22 2022, 12:05 PM

Don't open the modal unless we have the nonce

Harbormaster completed remote builds in B14695: Diff 20036.Dec 22 2022, 12:08 PM
Harbormaster completed remote builds in B14696: Diff 20037.Dec 22 2022, 12:19 PM
ashoat requested review of this revision.Dec 22 2022, 12:19 PM
atul accepted this revision.Dec 22 2022, 12:54 PM
This revision is now accepted and ready to land.Dec 22 2022, 12:54 PM
ashoat added inline comments.Dec 22 2022, 2:18 PM
landing/siwe.css
3 ↗(On Diff #20036)

Actually there's no reason that this should the same as landing... will separate them

ashoat added inline comments.Dec 22 2022, 2:52 PM
landing/siwe.css
3 ↗(On Diff #20036)

Harder than expected... creating backlog task: https://linear.app/comm/issue/ENG-2531/siwe-shouldnt-render-within-landing

ashoat updated this revision to Diff 20040.Dec 22 2022, 3:35 PM

Backdrop color

This revision was landed with ongoing or failed builds.Dec 22 2022, 3:36 PM
Closed by commit rCOMMe2ec8f39eec8: [landing] Style SIWE page a bit better and improve UX (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMe2ec8f39eec8: [landing] Style SIWE page a bit better and improve UX.
Harbormaster completed remote builds in B14699: Diff 20040.Dec 22 2022, 3:49 PM
ashoat added inline comments.Dec 23 2022, 7:49 AM
landing/siwe.css
1–3 ↗(On Diff #20041)

This borked landing page: https://linear.app/comm/issue/ENG-2535/landing-page-background-is-messed-up

ashoat mentioned this in D6015: [landing] Fix landing background.Dec 23 2022, 9:56 AM
ashoat mentioned this in rCOMMad89d12783d2: [landing] Fix landing background.Dec 23 2022, 10:18 AM
atul mentioned this in D6217: [web] Introduce `LoginFormWrapper` component.Jan 11 2023, 1:28 PM

Revision Contents
Changeset List

PathSize
landing/
25 lines
52 lines

Diff 20040

View Options

landing/siwe.css

Loading...
View Options

landing/siwe.react.js

Loading...