Page MenuHomePhabricator
Differential D6005

[lib/keyserver/native] move all the reaction message types into its own file
ClosedPublic
Actions

Authored by ginsu on Dec 22 2022, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 7:15 AM
Unknown Object (File)
Mon, Mar 17, 6:04 AM
Unknown Object (File)
Mon, Mar 17, 6:04 AM
Unknown Object (File)
Mon, Mar 17, 6:04 AM
Unknown Object (File)
Mon, Mar 17, 5:58 AM
Unknown Object (File)
Mar 3 2025, 1:47 AM
Unknown Object (File)
Mar 2 2025, 1:04 PM
Unknown Object (File)
Feb 18 2025, 9:37 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
tomek
atul
Commits
rCOMM6a41bf47ea2a: [lib/keyserver/native] move all the reaction message types into its own file
Summary

I don't know why I didn't do this from the start, but moved ReactionMessageData RawReactionMessageInfo and ReactionMessageInfo into a reaction messages type file. Almost all the other message types do this as well

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 22 2022, 3:29 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 22 2022, 3:29 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 22 2022, 3:43 PM
Harbormaster failed remote builds in B14698: Diff 20039!
Harbormaster completed remote builds in B14698: Diff 20039.Dec 22 2022, 3:55 PM
ginsu requested review of this revision.Dec 22 2022, 3:55 PM
ginsu added reviewers: atul, tomek.Dec 27 2022, 7:08 AM
ginsu added a child revision: D6054: [lib/native] move useCanCreateReactionFromMessage hook from native to lib.Dec 27 2022, 7:14 AM
tomek accepted this revision.Dec 29 2022, 4:58 AM
atul resigned from this revision.Dec 29 2022, 12:47 PM

Resigning to unblock since this was reviewed by @tomek.

This revision is now accepted and ready to land.Dec 29 2022, 12:47 PM
Closed by commit rCOMM6a41bf47ea2a: [lib/keyserver/native] move all the reaction message types into its own file (authored by ginsu). · Explain WhyDec 29 2022, 1:01 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6a41bf47ea2a: [lib/keyserver/native] move all the reaction message types into its own file.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
2 lines
lib/
shared/
2 lines
messages/
8 lines
types/
31 lines
messages/
29 lines
2 lines
native/
chat/
2 lines

Diff 20389

View Options

keyserver/src/responders/message-responders.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/shared/message-utils.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/shared/messages/reaction-message-spec.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/types/message-types.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/types/messages/reaction.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

native/chat/message-preview.react.js

Loading...