Page MenuHomePhabricator
Differential D6017

[native][landing] Resize BottomSheet when WalletConnect opened
ClosedPublic
Actions

Authored by ashoat on Dec 23 2022, 1:35 PM.
Tags
None
Referenced Files
F2904853: D6017.diff
Sun, Oct 6, 2:39 AM
Unknown Object (File)
Fri, Sep 20, 7:21 PM
Unknown Object (File)
Fri, Sep 20, 10:28 AM
Unknown Object (File)
Mon, Sep 16, 9:32 AM
Unknown Object (File)
Sun, Sep 15, 12:11 AM
Unknown Object (File)
Sat, Sep 14, 1:06 AM
Unknown Object (File)
Wed, Sep 11, 12:58 AM
Unknown Object (File)
Mon, Sep 9, 12:30 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM9234edae014b: [native][landing] Resize BottomSheet when WalletConnect opened
Summary

WalletConnect needs more space. See video.

Test Plan

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/siwe
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 23 2022, 1:35 PM
Herald added a subscriber: tomek. · View Herald TranscriptDec 23 2022, 1:35 PM
ashoat edited the test plan for this revision. (Show Details)Dec 23 2022, 1:39 PM
ashoat edited the test plan for this revision. (Show Details)Dec 23 2022, 1:44 PM
ashoat edited the test plan for this revision. (Show Details)Dec 23 2022, 1:47 PM
ashoat updated this revision to Diff 20081.Dec 23 2022, 1:49 PM

Don't need the snapToPosition stuff actually

Harbormaster completed remote builds in B14723: Diff 20080.Dec 23 2022, 1:50 PM
Harbormaster completed remote builds in B14724: Diff 20081.Dec 23 2022, 2:03 PM
ashoat requested review of this revision.Dec 23 2022, 2:03 PM
ashoat updated this revision to Diff 20082.Dec 23 2022, 2:56 PM

Three changes:

  1. Make it possible to increase the size of the BottomSheet. User may want to do this if eg. they don't have Coinbase wallet installed and they select it
  2. As a result, when the user closes WalletConnect modal, the WalletConnect snap point is not removed, so the BottomSheet doesn't resize. Added a React useEffect hook to keep the old behavior
  3. Factor bottom inset into bottom sheet heights for consistency between iOS and Android
Harbormaster completed remote builds in B14725: Diff 20082.Dec 23 2022, 3:11 PM
ashoat updated this revision to Diff 20084.Dec 23 2022, 3:17 PM

Remove console.log

ashoat added a parent revision: D6018: [landing] Fix SIWE behavior when no wallet installed on Android.Dec 23 2022, 3:23 PM
ashoat removed a parent revision: D6018: [landing] Fix SIWE behavior when no wallet installed on Android.
ashoat added a child revision: D6018: [landing] Fix SIWE behavior when no wallet installed on Android.
Harbormaster completed remote builds in B14727: Diff 20084.Dec 23 2022, 3:29 PM
atul accepted this revision.Dec 23 2022, 4:03 PM
atul added inline comments.
landing/siwe.react.js
136 ↗(On Diff #20084)

nit: think a newline after this would help visually separate the useCallback and useEffect with all the indentation

This revision is now accepted and ready to land.Dec 23 2022, 4:03 PM
ashoat updated this revision to Diff 20091.Dec 23 2022, 8:26 PM

Newline

This revision was landed with ongoing or failed builds.Dec 23 2022, 8:27 PM
Closed by commit rCOMM9234edae014b: [native][landing] Resize BottomSheet when WalletConnect opened (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM9234edae014b: [native][landing] Resize BottomSheet when WalletConnect opened.
Harbormaster completed remote builds in B14732: Diff 20091.Dec 23 2022, 8:41 PM

Revision Contents
Changeset List

PathSize
landing/
35 lines
lib/
types/
4 lines
native/
account/
39 lines

Diff 20082

View Options

landing/siwe.react.js

Loading...
View Options

lib/types/siwe-types.js

Loading...
View Options

native/account/siwe-panel.react.js

Loading...