[native] Animate BottomSheet closed on goBackToPrompt
ClosedPublic
Actions

Authored by ashoat on Dec 23 2022, 3:23 PM.

Details

Reviewers

atul

Commits

rCOMMe631cd1b01d6: [native] Animate BottomSheet closed on goBackToPrompt

Summary

goBackToPrompt gets called if the user presses the back button, or uses the Android hardware back button.

Before this diff, the BottomSheet would stay in place until it disappears when SIWEPanel unmounts. Now it will animate closed.

Test Plan

Press the back button and make sure the BottomSheet animates closed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 23 2022, 3:23 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 23 2022, 3:23 PM

ashoat added a parent revision: D6018: [landing] Fix SIWE behavior when no wallet installed on Android.Dec 23 2022, 3:24 PM

ashoat added a child revision: D6020: [native] Move Comm wordmark when SIWEPanel opened.Dec 23 2022, 3:34 PM

Harbormaster completed remote builds in B14728: Diff 20085.Dec 23 2022, 3:36 PM

ashoat requested review of this revision.Dec 23 2022, 3:36 PM

atul accepted this revision.Dec 23 2022, 3:58 PM

This revision is now accepted and ready to land.Dec 23 2022, 3:58 PM

Closed by commit rCOMMe631cd1b01d6: [native] Animate BottomSheet closed on goBackToPrompt (authored by ashoat). · Explain WhyDec 23 2022, 8:27 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe631cd1b01d6: [native] Animate BottomSheet closed on goBackToPrompt.

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

26 lines

siwe-panel.react.js

11 lines

Diff 20094

View Options

native/account/logged-out-modal.react.js