Paths

Table of Contentst

Differential D6034

[landing] Don't close SIWEPanel if RainbowKit connect modal successfully completed
ClosedPublic
Actions

Authored by ashoat on Dec 25 2022, 6:54 PM.

Tags

None

Referenced Files

	F2158759: D6034.diff
	Mon, Jul 1, 4:43 AM

	F2155726: D6034.id20119.diff
	Sun, Jun 30, 10:18 PM

	F2152949: D6034.id20114.diff
	Sun, Jun 30, 4:23 PM

	Unknown Object (File)
	Fri, Jun 21, 9:53 PM

	Unknown Object (File)
	Sat, Jun 15, 10:28 AM

	Unknown Object (File)
	Thu, Jun 13, 6:46 AM

	Unknown Object (File)
	Fri, Jun 7, 1:46 AM

	Unknown Object (File)
	Sat, Jun 1, 9:42 PM

View All 67 Files

Subscribers

Details

Reviewers

Commits

rCOMM78fd675e31f9: [landing] Don't close SIWEPanel if RainbowKit connect modal successfully…

Summary

The lines we're updating here are meant to catch RainbowKit closing. The modal will also disappear on success, but in that case signer will be set.

Test Plan

Make sure SIWEPanel closes when you press the X in the WebView, but not when you successfully auth with a wallet

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 25 2022, 6:54 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 25 2022, 6:54 PM

ashoat added a child revision: D6035: [native] Set SIWE WebView background color.Dec 25 2022, 6:55 PM

Harbormaster completed remote builds in B14749: Diff 20114.Dec 25 2022, 7:08 PM

ashoat requested review of this revision.Dec 25 2022, 7:08 PM

ashoat added inline comments.Dec 25 2022, 7:30 PM

landing/siwe.react.js
81 ↗	(On Diff #20114)	Snuck this in, no point returning anything from this function

atul accepted this revision.Dec 26 2022, 2:02 AM

This revision is now accepted and ready to land.Dec 26 2022, 2:02 AM

Closed by commit rCOMM78fd675e31f9: [landing] Don't close SIWEPanel if RainbowKit connect modal successfully… (authored by ashoat). · Explain WhyDec 26 2022, 4:51 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM78fd675e31f9: [landing] Don't close SIWEPanel if RainbowKit connect modal successfully….

ashoat removed a child revision: D6035: [native] Set SIWE WebView background color.Dec 26 2022, 4:51 AM

Revision Contents
Changeset List

Path

Size

landing/

5 lines

Diff 20119

landing/siwe.react.js

Loading...