[keyserver] Decouple `processSuccessfulLogin` from `logInResponder`
ClosedPublic
Actions

Authored by atul on Dec 28 2022, 6:50 AM.

Details

Reviewers

ashoat
tomek

Commits

rCOMMb9f4b7436f5c: [keyserver] Decouple `processSuccessfulLogin` from `logInResponder`

Summary

Pull out processSuccessfulLogin from logInResponder so the logic can be reused by siweAuthResponder.

These queries are run once password/signature are validated and the user has correctly authenticated.

Test Plan

Create account with password
Log in to ensure things work
Log out
Patch this diff in
Successfully able to log in again

Not a super comprehensive test plan, but it should be a pretty straightforward refactor.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 28 2022, 6:50 AM

atul published this revision for review.Dec 28 2022, 6:50 AM

atul edited the summary of this revision. (Show Details)Dec 28 2022, 6:53 AM

Harbormaster completed remote builds in B14811: Diff 20202.Dec 28 2022, 7:04 AM

atul added a child revision: D6060: [keyserver] Introduce `fetchUserIDForEthereumAddress` and use in `siweAuthResponder`.Dec 28 2022, 7:19 AM

Not really reviewing too closely, assuming it's just a refactor

This revision is now accepted and ready to land.Dec 28 2022, 2:07 PM

ashoat added inline comments.Dec 28 2022, 2:21 PM

keyserver/src/responders/user-responders.js
193 ↗	(On Diff #20202)	I might call this something other than "queries" since it also encompasses setting user cookie etc. Maybe `processSuccessfulLogin`?

atul added inline comments.Dec 28 2022, 10:27 PM

keyserver/src/responders/user-responders.js
193 ↗	(On Diff #20202)	Yeah, that's a clearer name.. will update this diff

address feedback (rename function)

atul retitled this revision from [keyserver] Decouple `successfulLogInQueries` from `logInResponder` to [keyserver] Decouple `processSuccessfulLogin` from `logInResponder`.Dec 28 2022, 10:37 PM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B14856: Diff 20261.Dec 28 2022, 10:44 PM

Closed by commit rCOMMb9f4b7436f5c: [keyserver] Decouple `processSuccessfulLogin` from `logInResponder`. · Explain WhyDec 28 2022, 10:47 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb9f4b7436f5c: [keyserver] Decouple `processSuccessfulLogin` from `logInResponder`.