Page MenuHomePhabricator
Differential D6061

[keyserver] Remove payloads from `siweAuthResponder` `ServerError`s
ClosedPublic
Actions

Authored by atul on Dec 27 2022, 11:32 PM.
Tags
None
Referenced Files
F5892568: D6061.id.diff
Thu, Apr 17, 8:14 AM
Unknown Object (File)
Tue, Apr 15, 9:30 PM
Unknown Object (File)
Tue, Apr 15, 9:30 PM
Unknown Object (File)
Tue, Apr 15, 9:30 PM
Unknown Object (File)
Mar 18 2025, 5:25 AM
Unknown Object (File)
Mar 15 2025, 11:02 PM
Unknown Object (File)
Mar 15 2025, 11:02 PM
Unknown Object (File)
Mar 15 2025, 11:02 PM
View All Files
Subscribers
None

Details

Reviewers
tomek
ashoat
Commits
rCOMMc4844d9fde08: [keyserver] Remove payloads from `siweAuthResponder` `ServerError`s
Summary

Context:
https://phab.comm.dev/D6033#181748
https://phab.comm.dev/D6033#181828

Basically looks like these status payloads are superfluous and aren't used anywhere... so cutting them.

Depends on D6060

Test Plan

Didn't really test... pretty confident this is a benign change.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
8 lines

Diff 20266

View Options

keyserver/src/responders/user-responders.js

#include "BlobItem.h" #include "BlobItem.h"
#include "Constants.h" #include "Constants.h"
#include <glog/logging.h>
namespace comm { namespace comm {
namespace network { namespace network {
namespace database { namespace database {
const std::string BlobItem::FIELD_BLOB_HASH = "blobHash"; const std::string BlobItem::FIELD_BLOB_HASH = "blobHash";
const std::string BlobItem::FIELD_S3_PATH = "s3Path"; const std::string BlobItem::FIELD_S3_PATH = "s3Path";
const std::string BlobItem::FIELD_CREATED = "created"; const std::string BlobItem::FIELD_CREATED = "created";
std::string BlobItem::tableName = BLOB_TABLE_NAME; std::string BlobItem::tableName = BLOB_TABLE_NAME;
BlobItem::BlobItem( BlobItem::BlobItem(
const std::string blobHash, const std::string blobHash,
const S3Path s3Path, const S3Path s3Path,
uint64_t created) uint64_t created)
: blobHash(blobHash), s3Path(s3Path), created(created) { : blobHash(blobHash), s3Path(s3Path), created(created) {
this->validate(); this->validate();
} }
BlobItem::BlobItem(const AttributeValues &itemFromDB) { BlobItem::BlobItem(const AttributeValues &itemFromDB) {
this->assignItemFromDatabase(itemFromDB); this->assignItemFromDatabase(itemFromDB);
} }
void BlobItem::validate() const { void BlobItem::validate() const {
LOG(INFO) << "[BlobItem::validate]";
if (!this->blobHash.size()) { if (!this->blobHash.size()) {
throw std::runtime_error("blobHash empty"); throw std::runtime_error("blobHash empty");
} }
this->s3Path.validate(); this->s3Path.validate();
} }
void BlobItem::assignItemFromDatabase(const AttributeValues &itemFromDB) { void BlobItem::assignItemFromDatabase(const AttributeValues &itemFromDB) {
LOG(INFO) << "[BlobItem::assignItemFromDatabase]";
try { try {
this->blobHash = itemFromDB.at(BlobItem::FIELD_BLOB_HASH).GetS(); this->blobHash = itemFromDB.at(BlobItem::FIELD_BLOB_HASH).GetS();
LOG(INFO) << "[BlobItem::assignItemFromDatabase] blob hash "
<< this->blobHash;
this->s3Path = S3Path(itemFromDB.at(BlobItem::FIELD_S3_PATH).GetS()); this->s3Path = S3Path(itemFromDB.at(BlobItem::FIELD_S3_PATH).GetS());
this->created = std::stoll( this->created = std::stoll(
std::string(itemFromDB.at(BlobItem::FIELD_CREATED).GetS()).c_str()); std::string(itemFromDB.at(BlobItem::FIELD_CREATED).GetS()).c_str());
} catch (std::logic_error &e) { } catch (std::logic_error &e) {
throw std::runtime_error( throw std::runtime_error(
"invalid blob item provided, " + std::string(e.what())); "invalid blob item provided, " + std::string(e.what()));
} }
this->validate(); this->validate();
Show All 29 Lines