Page MenuHomePhabricator

CommIOSNotifications module functionality definition
ClosedPublic

Authored by marcin on Dec 28 2022, 3:09 AM.
Tags
None
Referenced Files
F2134417: D6064.id21426.diff
Fri, Jun 28, 6:42 AM
F2132529: D6064.id20209.diff
Thu, Jun 27, 11:14 PM
Unknown Object (File)
Thu, Jun 27, 5:34 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 27, 5:03 PM
Subscribers

Details

Summary

This differential puts foundation for work on react-native-notifications replacement on iOS. It introduces necessary file group to XCode and introduces header file that defines notifications related API used across native code on iOS.

Test Plan

No test plan for this differential.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Rebase to add diff to commit description

I wonder if we should be defining this as a separate "module" (eg. old modules, TurboModules, Expo modules) rather than as a file in our app. We should weigh the pros and cons... one potential pro might be that we'll have access to more idiomatic ways of eg. dispatching events (see comment here).

Oh, I guess this *is* the old kind of module!! Never mind

This revision is now accepted and ready to land.Dec 29 2022, 5:48 AM

Define CommIOSNotifications as RCTEventEmitter

Remove method for handling local notifications from native public API. We are not using local notifications.

Move properties to header file - There is no reason to keep them in implementation file.