Page MenuHomePhabricator

[native] show loading icon while Comm account being registered via SIWE
ClosedPublic

Authored by kamil on Dec 28 2022, 6:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 10:51 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 13, 5:32 AM
Unknown Object (File)
Wed, Nov 13, 5:31 AM
Unknown Object (File)
Fri, Nov 8, 10:02 AM
Subscribers

Details

Summary

Context in ENG-2543

Normal flow on my dev environment:

After adding delay to keyserver:

Test Plan

Register via SIWE and check if loading is present (probably simulation of delay on keyserver will be needed)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
native/account/siwe-panel.react.js
177 ↗(On Diff #20217)

probably not needed but I wanted to make sure that after hypothetically adding another bottom sheet this functionality will work as previously

kamil published this revision for review.Dec 28 2022, 6:39 AM

Great work getting this done so quickly!!

This revision is now accepted and ready to land.Dec 28 2022, 6:47 AM