Page MenuHomePhabricator
Differential D6068

[native] show loading icon while Comm account being registered via SIWE
ClosedPublic
Actions

Authored by kamil on Dec 28 2022, 6:18 AM.
Tags
None
Referenced Files
F3389803: D6068.diff
Fri, Nov 29, 8:38 PM
Unknown Object (File)
Tue, Nov 26, 10:51 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 20, 6:17 PM
Unknown Object (File)
Wed, Nov 13, 5:32 AM
Unknown Object (File)
Wed, Nov 13, 5:31 AM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
ashoat
Commits
rCOMMab6b50be6d72: [native] show loading icon while Comm account being registered via SIWE
Summary

Context in ENG-2543

Normal flow on my dev environment:

After adding delay to keyserver:

Test Plan

Register via SIWE and check if loading is present (probably simulation of delay on keyserver will be needed)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Dec 28 2022, 6:18 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptDec 28 2022, 6:18 AM
kamil edited the summary of this revision. (Show Details)Dec 28 2022, 6:30 AM
kamil added inline comments.Dec 28 2022, 6:32 AM
native/account/siwe-panel.react.js
177

probably not needed but I wanted to make sure that after hypothetically adding another bottom sheet this functionality will work as previously

Harbormaster completed remote builds in B14826: Diff 20217.Dec 28 2022, 6:32 AM
kamil published this revision for review.Dec 28 2022, 6:39 AM
ashoat accepted this revision.Dec 28 2022, 6:47 AM

Great work getting this done so quickly!!

This revision is now accepted and ready to land.Dec 28 2022, 6:47 AM
Closed by commit rCOMMab6b50be6d72: [native] show loading icon while Comm account being registered via SIWE (authored by kamil). · Explain WhyDec 28 2022, 7:37 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMab6b50be6d72: [native] show loading icon while Comm account being registered via SIWE.

Revision Contents
Changeset List

PathSize
native/
account/
15 lines

Diff 20217

View Options

native/account/siwe-panel.react.js

Loading...